Line height about pixi-multistyle-text

[bluepichu]

So there's supposed to be a lineHeight property that you can add to any text style, but it doesn't seem to actually be applied anywhere in our code.

Actually, that style doesn't seem to be used anywhere in PIXI.Text either, even though it's listed in the documentation...

Implementing this shouldn't be too bad, though I'll have to think about how it plays with multiple font sizes and vertical alignments. (I'll probably just look into what CSS does and follow that as a guide.)

[bluepichu]

...though we'll also need to decide which units to use. I'd personally probably opt for a multiplier on the font size (CSS's unitless option), though interpreting it as a number of pixels (like CSS's length option) is also a reasonable choice.

[nmiguelmoura]

Hi,
Thank you.
I understand that, but in PIXI.Text, lineHeight works just fine.
The only thing for now that is preventing me from using MultiText for all my text fields in PIXI is this lineHeight property. Once its working, i'll make it my default text in my apps, because its great and solves me a lot of problems.
Congrats,
Nuno

[bluepichu]

Ah - apologies. I think I accidentally tested with a crazy-out-of-date copy of Pixi.

Looks like base Pixi uses the equivalent of CSS's length option, so we should stay consistent with that. That shouldn't be too hard to fold in; I'll try to include that with the new vertical align options.

[kuoruan]

lineHeight still not work. 😢

[bluepichu]

lineHeight does not work

[EloB]

I tried to solve lineHeight and it worked for me but I'm not sure about vertical align. I don't use that. Can someone test it?

#71

[tleunen]

@bluepichu - Would you have time to check out the suggested PR #71 ?

[andrew-ntk]

Will this bug be fixed in the near future?