Comments (4)
This can be closed I guess? See #78
from langchaingo.
Is it a necessity that the embedding model be an environment variable? These will be a finite set of values that could be defined as consts. Taking embeddings.NewOpenAI as an example, there is a need to provide an embedding name however that detail is somewhat hidden in the creation of the openai.New() struct which is called internally in the function and there is no comment which indicates the API Token and model are prerequisites
from langchaingo.
Is it a necessity that the embedding model be an environment variable? These will be a finite set of values that could be defined as consts. Taking embeddings.NewOpenAI as an example, there is a need to provide an embedding name however that detail is somewhat hidden in the creation of the openai.New() struct which is called internally in the function and there is no comment which indicates the API Token and model are prerequisites
There's a balance here between making the default high level API as simple as possible. I'm taking cues from upstream on this front.
The openai.WithModel() option enables this so I'm considering it closed. Please feel free to raise any discussion or propose any changes.
from langchaingo.
(To clarify, this was fixed in #78)
from langchaingo.
Related Issues (20)
- add fastembed-go
- Langchaingo can't handle latest embedding models HOT 1
- `memory.ConversationTokenBuffer` apparently doesn't consider the llm type to count tokens
- Ollama Package: Not handling context timeout issues on streaming response. HOT 2
- Azure openAI models
- docker-compose fails in pgvector-vectorstore-example with "The Compose file is invalid" error HOT 1
- [Improvement] TextSplitter: return chunk start and end position
- Unable to send BinaryPart to OpenAI Completions API
- Only the first tool is recognized
- Langchainjs formally supports Ollama functions. Can you support that too? HOT 7
- anthropic: add means to supply anthropic-beta header
- bug: SimilaritySearch with scoreThrehold not works with PgVector. HOT 2
- Support OpenAI structured outputs API HOT 1
- Provide supported model
- Custom multi-input tools HOT 3
- Suggestion: Refactoring LLMs Option Handling for Improved Clarity and Consistency
- [Improvement] Qdrant Store should allow the user to specify the wait condition when adding documents HOT 1
- Anthropic does not handle null content elegantly (panics)
- openai: use ollama in test
- The endpoints of gpt-3.5-turbo-instruct model are different. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from langchaingo.