GithubHelp home page GithubHelp logo

Comments (4)

obitech avatar obitech commented on August 26, 2024

This can be closed I guess? See #78

from langchaingo.

cduggn avatar cduggn commented on August 26, 2024

Is it a necessity that the embedding model be an environment variable? These will be a finite set of values that could be defined as consts. Taking embeddings.NewOpenAI as an example, there is a need to provide an embedding name however that detail is somewhat hidden in the creation of the openai.New() struct which is called internally in the function and there is no comment which indicates the API Token and model are prerequisites

from langchaingo.

tmc avatar tmc commented on August 26, 2024

Is it a necessity that the embedding model be an environment variable? These will be a finite set of values that could be defined as consts. Taking embeddings.NewOpenAI as an example, there is a need to provide an embedding name however that detail is somewhat hidden in the creation of the openai.New() struct which is called internally in the function and there is no comment which indicates the API Token and model are prerequisites

There's a balance here between making the default high level API as simple as possible. I'm taking cues from upstream on this front.

The openai.WithModel() option enables this so I'm considering it closed. Please feel free to raise any discussion or propose any changes.

from langchaingo.

tmc avatar tmc commented on August 26, 2024

(To clarify, this was fixed in #78)

from langchaingo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.