GithubHelp home page GithubHelp logo

Comments (2)

david-donachie avatar david-donachie commented on August 10, 2024

Presumably this would affect how hasVisited() (still works with a map, not with a drop), visited() (can only ever return 1, unless the map stores a counter?) and visitedTags() (presumably reliable with a map, and not a drop), work.

What would you think about something like a State.history.trim(maxVisits) method, which just cuts the history to have no more than X instances of a given passage? That might not really be a gain over using a map to record the number of visits per passage

from sugarcube-2.

tmedwards avatar tmedwards commented on August 10, 2024

To clarify, and assuming that the previous passage is recorded separately. Simply dropping expired moments will break the (entire) visited family of functions and the <<return>> macro. Switching to a Map([[name, visits]]) would only break the lastVisited() function as it's the only one that depends upon order.

The <<back>> macro and Jump To dialog are affected simply by expiring moments. Changing how expired moments are treated doesn't further affect them.

from sugarcube-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.