GithubHelp home page GithubHelp logo

Comments (6)

AlcaDesign avatar AlcaDesign commented on June 3, 2024 1

This is because you've added duplicate event handlers. Event handlers are not removed on disconnect.

from tmi.js.

samyan avatar samyan commented on June 3, 2024 1

You will eventually get this error message "(node) warning: possible EventEmitter memory leak detected. [...]" because that code will keep adding a new listener for the same message event every time "reconnect" is called.

async function reconnect() {
    await client.disconnect();
    await client.connect();
    client.on('message', messageHandler);
}
await reconnect();
// client._events.message is a function
await reconnect();
// client._events.message is now an array
console.log(client._events.message.length); // 2
await reconnect();
console.log(client._events.message.length); // 3
await reconnect();
console.log(client._events.message.length); // 4

Instead it should look more like this:

client.on('message', messageHandler);
async function reconnect() {
    await client.disconnect();
    await client.connect();
}

Thanks you for your response. I've tried in this way y seems to work:

// Desconectamos
await this.tmiClient.disconnect();
// Liberamos los triggers
this.tmiClient.removeAllListeners();

What do you think, is it good alternative for prevent duplication?

from tmi.js.

AlcaDesign avatar AlcaDesign commented on June 3, 2024 1

I think you're better off just moving when/where you add the listeners instead of removing all of them just to re-add them unnecessarily.

from tmi.js.

AlcaDesign avatar AlcaDesign commented on June 3, 2024

You will eventually get this error message "(node) warning: possible EventEmitter memory leak detected. [...]" because that code will keep adding a new listener for the same message event every time "reconnect" is called.

async function reconnect() {
    await client.disconnect();
    await client.connect();
    client.on('message', messageHandler);
}
await reconnect();
// client._events.message is a function
await reconnect();
// client._events.message is now an array
console.log(client._events.message.length); // 2
await reconnect();
console.log(client._events.message.length); // 3
await reconnect();
console.log(client._events.message.length); // 4

Instead it should look more like this:

client.on('message', messageHandler);
async function reconnect() {
    await client.disconnect();
    await client.connect();
}

from tmi.js.

samyan avatar samyan commented on June 3, 2024

Okey. Thank you very much!

from tmi.js.

juliocbgomes avatar juliocbgomes commented on June 3, 2024

This works for me! Thanks @samyan!!!

this.tmiClient.removeAllListeners();

from tmi.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.