some issues about db connection about fastapi-fullstack-boilerplate

[tmkontra]

Thanks @lwz7512 ! Thanks for catching these mistakes. I've pushed a patch that should resolve them.

To clarify around the get_db_session "dependency": I had previously used a dependency like one you have suggested. It usually works pretty well! However, it can unfortunately lead to unexpected behavior around session closure and possibly lead to deadlock. EDIT: I meant to say that I changed the codebase at one point, switching from the "dependency" to the raw context manager. That's why the invalid Depends(get_db_session) was present. I have kept it to illustrate both methods of db session creation.

I added the dependency version of get_db like you suggested, with a warning and a link to the github discussion about the possible issues. I personally recommend creating a db session within the body of each route.

[lwz7512]

thank you for update! I didn't realize the dead lock issue...I'd checkout it out.
Good work!