Comments (2)
Thanks @lwz7512 ! Thanks for catching these mistakes. I've pushed a patch that should resolve them.
To clarify around the get_db_session
"dependency": I had previously used a dependency like one you have suggested. It usually works pretty well! However, it can unfortunately lead to unexpected behavior around session closure and possibly lead to deadlock. EDIT: I meant to say that I changed the codebase at one point, switching from the "dependency" to the raw context manager. That's why the invalid Depends(get_db_session)
was present. I have kept it to illustrate both methods of db session creation.
I added the dependency version of get_db
like you suggested, with a warning and a link to the github discussion about the possible issues. I personally recommend creating a db session within the body of each route.
from fastapi-fullstack-boilerplate.
thank you for update! I didn't realize the dead lock issue...I'd checkout it out.
Good work!
from fastapi-fullstack-boilerplate.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastapi-fullstack-boilerplate.