About the m_rows and m_cols about qt_raytracer_challenge

[tobiasmarciszko]

Hey, I'm sorry I didn't pay attention to this comment before :) But if they are known at compile time they can/should be constexpr. and in this case I think they are, and hence they can be marked as constexpr :)

Did that answer your question?

[tobiasmarciszko]

Oh no, was is the static keyword the question was about not constexpr?

I need to check the code why it's static but my guess is that they can be static since every matrix object of a specific size that is instantiated share the same number of rows and cols, but they don't share the data :)

[tobiasmarciszko]

I'd say they are poorly named, the should be called m_numRows and m_numCols. The data that the matrix holds is inside m_data.