GithubHelp home page GithubHelp logo

Edge Browser not detected about ua-parser HOT 4 CLOSED

AHorak avatar AHorak commented on September 22, 2024
Edge Browser not detected

from ua-parser.

Comments (4)

bluesmoon avatar bluesmoon commented on September 22, 2024

The project has moved here: https://github.com/ua-parser/uap-core please file issues there. Also, this issue has been fixed: ua-parser/uap-core#72

from ua-parser.

AHorak avatar AHorak commented on September 22, 2024

Is there also a current NuGet Package for /ua-parser/uap-core?

from ua-parser.

bluesmoon avatar bluesmoon commented on September 22, 2024

I do not know what NuGet is, but if you look at the ua-parser project you might find something: https://github.com/ua-parser/

from ua-parser.

fourpastmidnight avatar fourpastmidnight commented on September 22, 2024

Using the c-sharp port via NuGet, I can confirm that this is an issue. Edge is not properly detected (it's probably being detected as Chrome, not Edge.) Because Edge attempts to look like Chrome, Edge detection must come before Chrome detection in the YAML regex files.

Edit
And, as @bluesmoon says (as does the README.md), the project has moved. However, the NuGet package for the C# implementation does still have an outdated YAML file included for the regex's. So Microsoft Edge detection is still "broken" in v1.2 of UAParser (that's the NuGet package name).

To fix it, I simply included the regexes.yaml file from the uap-core project mentioned above as an embedded resource in my assembly and used the Parser.FromYaml(string yaml) method to instantiate a parser. Using this method, Microsoft Edge was properly detected using the updated regex's.

from ua-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.