GithubHelp home page GithubHelp logo

Comments (4)

georgesittas avatar georgesittas commented on June 15, 2024

Hey @mr-miles, can you share a snippet that reproduces the issue here first?

from sqlglot.

mr-miles avatar mr-miles commented on June 15, 2024

Good idea!

from sqlglot import parse_one, exp

# find all tables (x, y, z)
for table in parse_one("SELECT * FROM x JOIN y JOIN z\r\n").find_all(exp.Table):
    print(table.name)

Blows up with qlglot.errors.TokenError

End the query with \r or \n on their own or some other whitespace and it is fine

from sqlglot.

georgesittas avatar georgesittas commented on June 15, 2024

I see, I can reproduce this issue - thanks! It seems like this is an edge case that we didn't test, apparently! Namely: having the \r\n sequence at the end of the SQL.

I'm not sure if your suggestion is the cleanest way to solve this issue, so I will probably look into this as well. Note that changes related to tokenization must be made for both the Python and the Rust tokenizer.

from sqlglot.

georgesittas avatar georgesittas commented on June 15, 2024

Check out the linked PR @mr-miles.

from sqlglot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.