Comments (4)
Hey @mr-miles, can you share a snippet that reproduces the issue here first?
from sqlglot.
Good idea!
from sqlglot import parse_one, exp
# find all tables (x, y, z)
for table in parse_one("SELECT * FROM x JOIN y JOIN z\r\n").find_all(exp.Table):
print(table.name)
Blows up with qlglot.errors.TokenError
End the query with \r or \n on their own or some other whitespace and it is fine
from sqlglot.
I see, I can reproduce this issue - thanks! It seems like this is an edge case that we didn't test, apparently! Namely: having the \r\n
sequence at the end of the SQL.
I'm not sure if your suggestion is the cleanest way to solve this issue, so I will probably look into this as well. Note that changes related to tokenization must be made for both the Python and the Rust tokenizer.
from sqlglot.
Check out the linked PR @mr-miles.
from sqlglot.
Related Issues (20)
- Parsing fails when struct / json field is called `select`
- MySQL read dialect doesn't support STRAIGHT_JOIN keyword
- Easier way to define type annotations for custom functions HOT 1
- Fix MS SQL and Subqueries HOT 1
- Clickhouse date_trunc makes upper arg1 (bad query) HOT 9
- Snowflake semi-structured data access syntax HOT 1
- Snowflake semi-structured data access syntax HOT 1
- Postgres to Sqlite CREATE TABLE does not translate GENERATED BY DEFAULT AS IDENTITY HOT 2
- Oracle materialized views WITH READ ONLY has Invalid expression / Unexpected token / required keyword format HOT 3
- Oracle TO_DATE function can't be parsed
- oracle unicode literals parse error HOT 1
- Evaluate jsqltranspiler test suite HOT 1
- The library didn't use a proper function to convert time to string when using parse_one HOT 1
- oracle comments inside column parenthesis breaks parsing HOT 2
- Regression in 25.1.0 when the write dialect is postgres and the read dialect is omitted HOT 1
- Snowflake Parser fails on columns called `case` HOT 2
- issue in transpile HOT 1
- Suppress errors HOT 1
- Snowflake: Select distinct off of a quoted column name without parenthesis doesn't parse correctly
- Transpiling `AT TIME ZONE` from redshift to bigquery
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlglot.