GithubHelp home page GithubHelp logo

The Controllable interface should be split out into a separate file, thus allowing the concrete Controllable implementation to inherit from it about contracts HOT 4 CLOSED

hiddentao avatar hiddentao commented on August 18, 2024
The Controllable interface should be split out into a separate file, thus allowing the concrete Controllable implementation to inherit from it

from contracts.

Comments (4)

mischat avatar mischat commented on August 18, 2024

From @novemberborn

Concept of “controller” is ambiguous in Controllable. Sometimes it’s the Controller contract, other times it’s the address that controls the Controller contract

from contracts.

mischat avatar mischat commented on August 18, 2024

from @draganm

Did like the fact that the constructor got passed in the Controller not the ControllerResolver ...

from contracts.

nostdm avatar nostdm commented on August 18, 2024

We could move the Controller interface to the controller.sol contract and then import it but that would add extra imports to each file. But then we could extend the interface so that the compiler can enforce it (to be honest I rarely see contracts inheriting interfaces in solidity most of the time interfaces are used to communicate with an external contract)

from contracts.

nostdm avatar nostdm commented on August 18, 2024

Fixed #177

from contracts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.