assertion failed: meta.is_event() about console

[hds]

@dinhani Thanks for your issue report!

I would say that this is definitely incorrect on console-api side, even in debug mode we should be more resilient.

This will only happen if the console-subscriber is receiving traces that aren't from Tokio, since in the Tokio instrumentation we only use events and spans, but if we're going to have this assertion in place, we should be filtering out non-event/non-span callsites and not sending them on to the aggregator (we won't do anything with them anyway).

If you're interested in working on this, I propose that we check that the metadata received by register_callsite is either an event or a span, and otherwise we return Interest::never() and don't do any more:

console/console-subscriber/src/lib.rs

Line 531 in a0d20fd

fn register_callsite(&self, meta: &'static Metadata<'static>) -> subscriber::Interest {

We could add a test for this behaviour, although it looks like our test set-up doesn't fail the test when the subscriber thread panics, which is weird. I'll look at that separately.

[dinhani]

I tested my project with the suggested change at register_callsite and it worked. There are no more panics.

I sent the suggested PR, but I still need to check how to test it properly in this project.