Allow access for Runtime struct? about tokio-uring

[ileixe]

I just found recent PR(#88) to achieve it.

[nik9000]

I think it might be useful to constrain this issue to something like "make tokio-uring work with criterion" - whatever makes that work is fine by me, at least. Does anyone have any other reasons for referencing the Runtime struct?

[nik9000]

FWIW I'd be happy to open a PR for this, but I might need some guidance on the "shape" that you'd like it in. Is this something that you'd make a feature for? That feels odd to me because criterion is usually a dev dependency.

[Noah-Kennedy]

For an API, I think it should look like the normal tokio runtime API, except with only spawn, block_on, new, and spawn_blocking. We can add a handle as well, either here or later.

[nik9000]

So you are thinking of making the struct public with public implementations with the same signature as those methods? I might be able to have a look in the next few days. Or, if you want it, please go ahead. I don't know what I'm doing and I don't get in the way.

[nik9000]

When I pull this locally I get a few test failures randomly - explicit_close and drop_off_runtime and sometimes the tests hang around the same place. Is that normal?

[Noah-Kennedy]

What kernel do you have?

[nik9000]

Linux porco 5.19.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 29 Aug 2022 15:51:05 +0000 x86_64 GNU/Linux

[Noah-Kennedy]

@nik9000 see #119.

[FrankReh]

When I pull this locally I get a few test failures randomly - explicit_close and drop_off_runtime and sometimes the tests hang around the same place. Is that normal?

As you indicated in #119, that problem from Sep seems fixed.

[FrankReh]

I'm glad the question of a handle came up in this thread already.