GithubHelp home page GithubHelp logo

Comments (5)

aturon avatar aturon commented on June 8, 2024

Fine by me.

from tokio.

alexcrichton avatar alexcrichton commented on June 8, 2024

This was originally added in tokio-rs/tokio-core#149 to solve tokio-rs/tokio-core#147 which was in turn targeted at alexcrichton/tokio-signal#6 which removed the need for keeping the original event loop alive once you're creating signal handlers.

With no ability to spawn this doesn't really make any more sense as the whole point was to "spawn a thing per event loop" or "spawn one thing globally and only one". That being said I have no idea how this will actually get implemented for signal handling...

from tokio.

carllerche avatar carllerche commented on June 8, 2024

I'm not sure what exactly requires one task per executor in order to handle signals (which is what it seems like it is trying to do).

My initial thought would be that logic that pushes signals to the associated streams would be handled the same way as timers.

from tokio.

aturon avatar aturon commented on June 8, 2024

In any case it seems prudent to start without it at first, and then revisit tokio-signal; it's easy to add back if needed.

from tokio.

carllerche avatar carllerche commented on June 8, 2024

Fixed by #41

from tokio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.