Comments (1)
I believe I've figured out what's going wrong here. Your not_working
implementation records the error's cause by calling Valuable::as_value
on it: https://github.com/jaskij/valuable-serde-bug-reproduction/blob/017613b07dfdf692d869573bbfbd099c73d58398/not_working/src/valuable_anyhow.rs#L31
Since root_cause
is an Error
, its as_value
implementation returns Value::Error
. This is correct. However, it's also why this code doesn't work. Note that the difference between the working
code and the not_working
code is that in working
, error.root_cause()
is formatted as a String
first: https://github.com/jaskij/valuable-serde-bug-reproduction/blob/017613b07dfdf692d869573bbfbd099c73d58398/working/src/main.rs#L26
The problem is due to a bug in valuable-serde
when recording the Value::Error
variant. When valuable-serde
encounters a Value::Error
, it returns the error immediately as a serialization error:
valuable/valuable-serde/src/lib.rs
Line 267 in 1fc2ad5
This is not correct. If a serde
serializer returns an error, this means something has gone wrong while serializing a value. Returning an error makes the serialization fail. However, this is not what valuable
's Value::Error
means. Value::Error
represents that we are recording a value which happens to be an Error
, not that something went wrong while recording the value. This means that valuable-serde
will currently return an Error
(indicating that serialization failed) any time it attempts to record an Error
value.
Instead, it should probably record the string representation of the error using serialize_str
or something.
from valuable.
Related Issues (20)
- `NamedValues::get` footgun.
- Feature request: Expose doc comments for struct/enum/field definitions HOT 1
- Feature request: Allow reading structable attributes
- the trait `tracing::Value` is not implemented for `valuable::Value<'_> HOT 2
- question: is valuable expected to work with tracing macros? HOT 1
- Create a span for plugin init HOT 1
- Constructing objects from `Value`
- derive: implement #[valuable] attributes HOT 3
- Add a way to iterate on non-primitives/visit specific slices for Listable
- Visitor holding `Value` HOT 13
- Consider adding a concrete lifetime to the Visit trait HOT 1
- Consider changing Value::Error to &(dyn Error + 'static) HOT 1
- Owned [NamedField] for Fields HOT 10
- Consider Visit::visit_key + Visit::visit_value HOT 4
- Release initial version HOT 6
- publish `valuable-serde`
- `dyn Display` primitive value HOT 1
- How should we implement Valuable for Uuid? HOT 3
- Introduce a lifetime generic to `Visit` in order to allow borrowing out specific parts of the `valuable::Value` during visits HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valuable.