GithubHelp home page GithubHelp logo

UI updates about pathways HOT 11 CLOSED

c-brenn avatar c-brenn commented on June 2, 2024
UI updates

from pathways.

Comments (11)

22a avatar 22a commented on June 2, 2024 1

yes v relevant, will be able to write helper functions that render real html elements in the result panels instead of overwriting .innerHTML, should be 🍑y

from pathways.

c-brenn avatar c-brenn commented on June 2, 2024

From @22a's comment on #107 :

  • what do we want to display to the user when the request chain is broken at the different points (when found URI's is less than 2 and when identifiable drugs is less than 0{thinking about this, this should also probably be 2, as there's no point getting the uri of one drug alone})

  • do we want to make the error panel more expressive (where we can change the panel header as well)

from pathways.

c-brenn avatar c-brenn commented on June 2, 2024

#89 is probably relevant to this

from pathways.

c-brenn avatar c-brenn commented on June 2, 2024

Improving the error messages that panacea sends back would probably go a long way in helping the UI show nice error messages.

Instead of just getting back {message: "..."} it should probably return some JSON with the type of error and some useful bits - line number for pml errors for example. The JS can construct whatever error message it likes from that info instead of having to pass along the hardcoded one from panacea.

from pathways.

22a avatar 22a commented on June 2, 2024

as mentioned in slack, swapping these two lines would be a temporary solution to display when no drugs are found. Long term we probably want an error type message instead of a green-success box with an empty list literal

from pathways.

laurmurclar avatar laurmurclar commented on June 2, 2024

For the moment I'm just going to test that no panels are shown when there's no drugs.

from pathways.

22a avatar 22a commented on June 2, 2024

@laurmurclar well i suppose at least some feed back should be given to the user that there was no parseable drugs in the pml file they uploaded

from pathways.

laurmurclar avatar laurmurclar commented on June 2, 2024

Oh yeah absolutely, but I don't want to mix that change in with the test stuff. I can add a no drugs message now

from pathways.

22a avatar 22a commented on June 2, 2024

Oh okay sorry yes ofc! 🙏

from pathways.

c-brenn avatar c-brenn commented on June 2, 2024

there was some more discussion on slack today. The broad idea that came from it was:

  • display the found drugs from the /api/uris response in the drugs panel, not the labels from /api/pml
  • if possible, the found drugs should link to some chemistry/medical website (e.g. https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:15377 <- takes a chebi id
  • if there are any unidentified drugs show the PML file contents and highlight them
  • if there are any DDIs, show the PML file contents and highlight them

from pathways.

c-brenn avatar c-brenn commented on June 2, 2024

a distant memory

from pathways.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.