Comments (11)
yes v relevant, will be able to write helper functions that render real html elements in the result panels instead of overwriting .innerHTML
, should be 🍑y
from pathways.
-
what do we want to display to the user when the request chain is broken at the different points (when found URI's is less than 2 and when identifiable drugs is less than 0{thinking about this, this should also probably be 2, as there's no point getting the uri of one drug alone})
-
do we want to make the error panel more expressive (where we can change the panel header as well)
from pathways.
#89 is probably relevant to this
from pathways.
Improving the error messages that panacea sends back would probably go a long way in helping the UI show nice error messages.
Instead of just getting back {message: "..."}
it should probably return some JSON with the type of error and some useful bits - line number for pml errors for example. The JS can construct whatever error message it likes from that info instead of having to pass along the hardcoded one from panacea.
from pathways.
as mentioned in slack, swapping these two lines would be a temporary solution to display when no drugs are found. Long term we probably want an error type message instead of a green-success box with an empty list literal
from pathways.
For the moment I'm just going to test that no panels are shown when there's no drugs.
from pathways.
@laurmurclar well i suppose at least some feed back should be given to the user that there was no parseable drugs in the pml file they uploaded
from pathways.
Oh yeah absolutely, but I don't want to mix that change in with the test stuff. I can add a no drugs message now
from pathways.
Oh okay sorry yes ofc! 🙏
from pathways.
there was some more discussion on slack today. The broad idea that came from it was:
- display the found drugs from the
/api/uris
response in the drugs panel, not the labels from/api/pml
- if possible, the found drugs should link to some chemistry/medical website (e.g.
https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:15377
<- takes a chebi id - if there are any
unidentified drugs
show the PML file contents and highlight them - if there are any
DDIs
, show the PML file contents and highlight them
from pathways.
a distant memory
from pathways.
Related Issues (20)
- Report PML construct name-clash HOT 9
- PML-TX Save PML to File HOT 5
- Release 1 Feedback HOT 1
- Specify a Delay HOT 5
- Identify Parallel DDIs HOT 2
- Identify Sequential DDIs HOT 2
- Mock DDI Characterisation Data
- Real DDI Mock Good-Bad Time Generator
- Real DDI Agonist-Antagonist Mock Time Generator
- Locked down versions for e2e compose
- Release 2 UI HOT 3
- improve Parser/Lexer errors
- app.js refactor HOT 1
- Tabbed UI HOT 1
- DDI line numbers
- Tab UI testing docs overhaul
- `Save PML File` documentation
- Remove warnings
- Final UI discussion HOT 1
- Final doc check
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pathways.