Header host missing port about needle

[tomas]

Hey Boris,

I think we had this but at some point it was removed. Are you sure the Host header can or should include the port as part of its value? AFAIK the port is only used for establishing the connection to that specific port on a server, and has nothing to do with the Host itself.

[Alexander-Boris-de-Pfeffel-Johnson]

Hi Tomas!

Thanks for the response

I think it should be in some cases, am no expert in this field but dug up some spec from w3

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

"A "host" without any trailing port information implies the default port for the service requested (e.g., "80" for an HTTP URL)"

Unfortunately this slight edge case is an issue am bumping into

[tomas]

Would you mind sharing the code that's giving you trouble, so I can reproduce the bug?

[Alexander-Boris-de-Pfeffel-Johnson]

Sorry for the long delay. Please excuse the rather noobish code below (with a funky infinite loop). Have tested it in the context on my app, but it should still work externally. The first time, from a browser, will show the headers.host as ''localhost:8081". The second time around from needle will show just "localhost".

express().all("", function (req, res) {

    console.log("Host is... " + req.headers.host);

    var url = "http://localhost:8081" ;

    needle.get(url, {}, function() {});

}

express().listen(8081)

Hopefully this should be enough to get the gist, but I think the port will be missing in whatever way the original needle command is made

[tomas]

Hey Boris, sorry for the delay mate. What do you mean by first and second time? Because of a redirect?

[Alexander-Boris-de-Pfeffel-Johnson]

Sorry, the needle request will loop back into the same code. So the first time the context is a standard call to node, the second time will be the needle get request. First time the host contains the port, the second time from needle the host does not contain the port

[tomas]

Ok sir, just tested and fixed it. Pushing 0.6.1 as we speak... Thanks again for reporting!

[Alexander-Boris-de-Pfeffel-Johnson]

Hey no problem! Mucho thanks for taking the time to chat and fix it :)