Comments (7)
Sorry for not responding earlier. Would you submit a pull request including this change?
from needle.
This would introduce another dependency of charset, is this okay?
mime checking at needle.js would also be changed.
from needle.
Hmm. I guess you're right. In the end it's as simple as doing this, right?
if (!mime.charset && mime.type == 'text/html') {
var found = body.toString().match(/[charset|encoding]=([^\"]+)/);
if (found) mime.charset = found[1];
}
I don't think we really need another dependency.
from needle.
Yup, I would also suggest using body.toString().slice(1, 1024).match()
to look for the first 1024 bytes only.
from needle.
Ok, thanks.
from needle.
I was studying the latest code and didn't realize the meta handling in decoder.js
was added because of me
from needle.
heys @tomas how about including jschardet for charset auto-detect, if not found
in <meta>
?
at https://github.com/tomas/needle/blob/master/lib%2Fneedle.js#L105
i'm currently using the library and all seems well now
from needle.
Related Issues (20)
- Support NO_PROXY and no_proxy HOT 2
- Strange serialization with arrays using post method HOT 1
- Potential security issue HOT 5
- Issue with webpack and react-native HOT 1
- `err` event not triggered on endless redirects (node16 specific) HOT 3
- Incorrect method
- ECONNRESET thrown after connection closed HOT 1
- Test failures on macOS w/ node v17 HOT 1
- Test failures on node v14-v16 HOT 3
- Test failures on node v4-v12
- Incorrect parsing of complex JS nested objects in POST request HOT 5
- Mangled file content when multipart-POSTing a file with a "text/*" content type HOT 2
- Very infrequent TypeError: iconv.encodingExists is not a function
- Tunnelling doesn't work in v3.1.0 HOT 12
- Proposal: Supporting User-Defined "Follow If" Conditions
- Piping needle request to Express response won't set the correct headers
- Multiple Files Upload Renames Input Field
- Uncaught asynchronous error
- Remote end closed socket abruptly errors HOT 2
- a ':' in nonce breaks digest authentication HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from needle.