GithubHelp home page GithubHelp logo

Comments (7)

tomas avatar tomas commented on July 19, 2024

Sorry for not responding earlier. Would you submit a pull request including this change?

from needle.

leesei avatar leesei commented on July 19, 2024

This would introduce another dependency of charset, is this okay?
mime checking at needle.js would also be changed.

from needle.

tomas avatar tomas commented on July 19, 2024

Hmm. I guess you're right. In the end it's as simple as doing this, right?

if (!mime.charset && mime.type == 'text/html') {
  var found = body.toString().match(/[charset|encoding]=([^\"]+)/);
  if (found) mime.charset = found[1];
}

I don't think we really need another dependency.

from needle.

leesei avatar leesei commented on July 19, 2024

Yup, I would also suggest using body.toString().slice(1, 1024).match() to look for the first 1024 bytes only.

from needle.

tomas avatar tomas commented on July 19, 2024

Ok, thanks.

from needle.

leesei avatar leesei commented on July 19, 2024

I was studying the latest code and didn't realize the meta handling in decoder.js was added because of me 😛.

from needle.

fritx avatar fritx commented on July 19, 2024

heys @tomas how about including jschardet for charset auto-detect, if not found in <meta>?
at https://github.com/tomas/needle/blob/master/lib%2Fneedle.js#L105
i'm currently using the library and all seems well now

from needle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.