Final part has extra \r\n on end about needle

[tomas]

Which part? I've tested on a number of different servers and it works without a problem (I actually read the spec for multipart POST's). If you can show an example it'd also help.

[OrangeDog]

Using https://github.com/felixge/node-formidable as the parser in the server, and sending a single field via multipart, the end of the request looks like this:

----------------------NODENEEDLEHTTPCLIENT
Content-Disposition: form-data; name="name"

value

----------------------NODENEEDLEHTTPCLIENT--

And on the server JSON.stringify(params.name) gives "value\r\n"

[OrangeDog]

The problem is that "\r\n" is added to the end of every return_part, and then duplicated at the start of the final boundary.

[tomas]

Ok I'll do a test with formidable and fix it if needed. Thanks for the heads up.

[abh]

I agree with OrangeDog that the current code looks wrong in this respect. :-)

[tomas]

Ok, tested with formidable. Removing the last \r\n before the final boundary does work. I reread the spec and indeed there is no mention of a double \r\n at the end -- don't really remember why I added it in the first place -- so I'm removing it. Thanks guys.