GithubHelp home page GithubHelp logo

Comments (5)

tomas avatar tomas commented on July 19, 2024

Yes that definitely seems to be the problem. 0.7.0 uses the 'streams2' interface so it relies on the 'readable' event, not the 'data' one. Do you think the nock guys will take a look at this?

from needle.

jbergknoff avatar jbergknoff commented on July 19, 2024

I'm not sure whether they'll be open to work on it. Is it feasible for needle to listen for the deprecated (non-streams2) event?

from needle.

tomas avatar tomas commented on July 19, 2024

As long as it doesn't force the stream into flowing mode, we could do something. Although I think the nock guys have the real responsibility of providing a solution, don't you think?

from needle.

jbergknoff avatar jbergknoff commented on July 19, 2024

I don't have a strong enough understanding of node.js streams, and the status of streams2, to say if it's their responsibility. I will ask about it in the issue that I linked, though.

from needle.

jbergknoff avatar jbergknoff commented on July 19, 2024

I believe this issue has been addressed by changes in nock; thanks for your consideration.

from needle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.