HTTP Status Code 303 See Other not treated as redirect about needle

[tomas]

Good to know. Can you send an example of a server that sends a 303?

[haohcraft]

@flore2003 I think you should set cookie in the header when 302, so in the lib/needle.js:

   if ([301, 302].indexOf(resp.statusCode) != -1 && headers.location) {
         if (count <= config.follow) {
         // --------------------------------------------------
         // must set cookie
         var cookies = headers['set-cookie'];
      if ( cookies ) {
        config.base_opts.headers.Cookie = cookies[0];
      }
      // --------------------------------------------------
       out.emit('redirect', headers.location);

Credits: #40

[tomas]

Needle doesn't handle cookies (yet) , but I'd be happy to merge a Pull Request with some tests. :)

[flore2003]

@haohcraft I don't understand what your comment has to do with this issue.
This issue is about HTTP Status 303 See Other, which is a valid response code for example for a POST request that creates a resource. The location header will be set to the location of the newly created resource.

@tomas I don't have an example for a public facing server that responds with a 303, but you can read more about it in the HTTP 1.1 RFC! http://tools.ietf.org/html/rfc2616#page-63

[tomas]

@flore2003 303 handling is already on master. I just pushed a branch that includes a couple of other enhancements to the redirect follow logic, that should be merged once I get all the specs to pass. Then I'll be pushing a new version over to npmjs.org. :)

[flore2003]

@tomas Great! I'll check it out =)