GithubHelp home page GithubHelp logo

Comments (7)

tomas avatar tomas commented on July 19, 2024

Simple: what's the point of setting any other properties if they won't be used anyway?

from needle.

dr0r avatar dr0r commented on July 19, 2024

Why wouldn't they be used..?
For example setting gzip: true, and setting headers, etc..
Don't see a reason not to allow this..

from needle.

tomas avatar tomas commented on July 19, 2024

Ok then what you really mean is why do we not include additional properties in the defaults object. I don't really see why not. Which do you specifically want to be added?

from needle.

dr0r avatar dr0r commented on July 19, 2024

gzip, headers{Content-Type, Accept-Encoding}.

Why not have defaults accept new properties, and in needle.request take anything from defaults if it's not set in options?

from needle.

tomas avatar tomas commented on July 19, 2024

Because it's not that simple. Each property from the defaults object is used in a specific part.

Why don't you submit a Pull Request? :)

from needle.

dr0r avatar dr0r commented on July 19, 2024

Perhaps I will :)

from needle.

mediafreakch avatar mediafreakch commented on July 19, 2024

Adding the username & password properties would be nice :)

from needle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.