FF 19.0 document.body errors as null. about detect-zoom

[tombigel]

1st - document.body works everywhere since 1992... I can't see a scenario it does not exist. 

2nd - $ assumes jquery or compatible framework, and detect-zoom is framework agnostic. 
—
Sent from Mailbox for iPhone

On Fri, Mar 1, 2013 at 9:10 PM, jnmichaud [email protected]
wrote:

This error causes the entire detectZoom file to fail.
I replaced document.body.style.webkitTextSizeAdjust === 'string' with $.browser.webkit === true (as I am using jquery).

Thought you should know.

Reply to this email directly or view it on GitHub:
#32

[nick4fake]

And third - $.browser is deprecated and removed in latest jquery versions

[jnmichaud]

I appreciate the reply. Considering what you're doing, I think the info
about Jquery is pretty irrelevant to the situation. (The only reason I put
it in there is to demonstrate that I had to change your code and use a
bypass.)

As to document.body working or not... All I can tell you is that as of my
post, it was throwing errors in FireFox 19.0 and it stops the entire file
from loading or working so I had to do something to make it work. I'm using
the release update channel of firefox. I expect it's probably their error
and not yours, but it's doing what it's doing. What you decide to do about
that is up to you.

On Sun, Mar 3, 2013 at 6:02 AM, Bogdan Yurov [email protected]:

And third - $.browser is deprecated and removed in latest jquery versions

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-14346614
.

[tombigel]

What you are saying is pretty strange. I checked on FF 19.0 (Release
channel) and document, document.body, document.body.style are all there.

does the example on http://tombigel.github.com/detect-zoom/ work for you?

On Sun, Mar 3, 2013 at 3:23 PM, jnmichaud [email protected] wrote:

I appreciate the reply. Considering what you're doing, I think the info
about Jquery is pretty irrelevant to the situation. (The only reason I put
it in there is to demonstrate that I had to change your code and use a
bypass.)

As to document.body working or not... All I can tell you is that as of my
post, it was throwing errors in FireFox 19.0 and it stops the entire file
from loading or working so I had to do something to make it work. I'm
using
the release update channel of firefox. I expect it's probably their error
and not yours, but it's doing what it's doing. What you decide to do about
that is up to you.

On Sun, Mar 3, 2013 at 6:02 AM, Bogdan Yurov [email protected]:

And third - $.browser is deprecated and removed in latest jquery
versions

—
Reply to this email directly or view it on GitHub<
https://github.com/tombigel/detect-zoom/issues/32#issuecomment-14346614>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-14346882
.

[jnmichaud]

Yes, actually it does.

Apparently the issue is with my site and not the file.

I have no idea why that would be the case. I'll have to look into it.
(document.body is showing as null for me, on my project.)

I apologize for the mistake.

On Sun, Mar 3, 2013 at 6:38 AM, Tom [email protected] wrote:

What you are saying is pretty strange. I checked on FF 19.0 (Release
channel) and document, document.body, document.body.style are all there.

does the example on http://tombigel.github.com/detect-zoom/ work for you?

On Sun, Mar 3, 2013 at 3:23 PM, jnmichaud [email protected]
wrote:

I appreciate the reply. Considering what you're doing, I think the info
about Jquery is pretty irrelevant to the situation. (The only reason I
put
it in there is to demonstrate that I had to change your code and use a
bypass.)

As to document.body working or not... All I can tell you is that as of
my
post, it was throwing errors in FireFox 19.0 and it stops the entire
file
from loading or working so I had to do something to make it work. I'm
using
the release update channel of firefox. I expect it's probably their
error
and not yours, but it's doing what it's doing. What you decide to do
about
that is up to you.

On Sun, Mar 3, 2013 at 6:02 AM, Bogdan Yurov [email protected]:

And third - $.browser is deprecated and removed in latest jquery
versions

—
Reply to this email directly or view it on GitHub<
https://github.com/tombigel/detect-zoom/issues/32#issuecomment-14346614>

.

—
Reply to this email directly or view it on GitHub<
https://github.com/tombigel/detect-zoom/issues/32#issuecomment-14346882>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-14347039
.

[hon2a]

The same issue is happening to me in current Chrome release (version 27.0.1453.94). The example you linked works. The difference between the two is the deployment method. Your example includes the script at the end of <body> element. Our application includes JS sources inside the <head> element.

To support this (valid) deployment method, your module shouldn't start its initialization on its own (before the document is ready). Instead, it could either expose an initialization method (which we'd call when the document is ready), or call it internally on first call of the exposed methods.

[jnmichaud]

Thank you. I'd assumed it was something like that (and I basically did just
that and bypassed most of the problem).

Much appreciated

On Fri, May 24, 2013 at 1:35 PM, hon2a [email protected] wrote:

The same issue is happening to me in current Chrome release (version
27.0.1453.94). The example you linked works. The difference between the two
is the deployment method. Your example includes the script at the end of
element. Our application includes JS sources inside the element.

To support this (valid) deployment method, your module shouldn't start its
initialization on its own (before the document is ready). Instead, it could
either expose an initialization method (which we'd call when the document
is ready), or call it internally on first call of the exposed methods.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-18425357
.

[hon2a]

I'm not sure what you mean by that, but the latest commit still has the reported bug. To fix it, the detectFunction generator should be run on first use instead of on script inclusion. Like:

var detectFunction,
    selectDetectFunction = function () { /* detect function generator */ },
    initialize = function () {
        if (!detectFunction) {
            detectFunction = selectDetectFunction();
        }
    };

return {
    zoom: function () {
        initialize();
        return detectFunction().zoom;
    },
    device: function () {
        initialize();
        return detectFunction().devicePxPerCssPx;
    }
};