GithubHelp home page GithubHelp logo

Comments (6)

tomchavakis avatar tomchavakis commented on August 21, 2024 1

@AaronFeickert,
You are right pull request #62 doesn't fix this issue.
The #61 is working only if you use the flag export-license-texts in case that you want to have all the licenses in text files.
Unfortunately, there are other cases with other licenses that instead of text the output is HTML.
I'll try to fix it asap.

from nuget-license.

ChrisMcKee avatar ChrisMcKee commented on August 21, 2024
new HttpClient(new HttpClientHandler
{
    AllowAutoRedirect = true,
    MaxAutomaticRedirections = 5
});

from nuget-license.

tomchavakis avatar tomchavakis commented on August 21, 2024

Hi @AaronFeickert ,

Thank you for pointing this out.
I have updated the code to handle possible redirections.
#62

On the other hand, the tool retrieves the license URL from the nuget API.

@ChrisMcKee, if you go at the following nuget page
https://www.nuget.org/packages/BCrypt.Net-Next/
you will see that the license of the project is linked with the master instead of main branch.
As a result, the tool will present the license which is associated with nuget.
A possible solution would be to make an extra call to the github URL and if the github redirects to main branch then update the license URL but I am not sure if this is the expected way.

from nuget-license.

ChrisMcKee avatar ChrisMcKee commented on August 21, 2024

Yeah it's sorted in GitHub. Damn branch renaming joys

from nuget-license.

AaronFeickert avatar AaronFeickert commented on August 21, 2024

The linked pull request #62 does not appear to fix this.

from nuget-license.

tomchavakis avatar tomchavakis commented on August 21, 2024

@AaronFeickert , I'll close this issue which resolved with this PR:
#63

from nuget-license.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.