GithubHelp home page GithubHelp logo

Update to react v15.0 about react-split-pane HOT 3 CLOSED

tomkp avatar tomkp commented on May 14, 2024 1
Update to react v15.0

from react-split-pane.

Comments (3)

kachkaev avatar kachkaev commented on May 14, 2024 3

Found at least one thing to change after upgrading to React 15.

This warning comes out when defaultSize is saved to and then read from LocalStorage:

warning.js:44 Warning: a `div` tag (owner: `Pane`) was passed a numeric string value for CSS property
`width` (value: `298`) which will be treated as a unitless number in a future version of React.warning
@ warning.js:44dangerousStyleValue

Easy to fix:

defaultSize={ localStorage.getItem('splitPos') }

defaultSize={ parseInt(localStorage.getItem('splitPos'), 10) }

from react-split-pane.

tomkp avatar tomkp commented on May 14, 2024 1

I've pushed the change to the readme. Is this issue Ok to be closed now?
Thanks

from react-split-pane.

kachkaev avatar kachkaev commented on May 14, 2024

React is 15+ since 36eb246. @tomkp could you please update that example with localStorage in README.md (see above)? We can then close this issue.

from react-split-pane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.