Comments (8)
I think overall it's like you said - more ducking, less audio clarity, but we didn't do any objective measurements on it yet.
Speaking of which, I'm not sure of the formal approaches you would take to evaluate audio quality, I've always just kind of done side-by-side listening comparisons. Maybe it's like you said, we just need to configure it more properly.
Either way, a PR on top of #23 or a PR on top of the main branch will be fine.
from webrtc-audio-processing.
Making a PR on top of main branch and reverting our app to use it too!
from webrtc-audio-processing.
Can it be related to this line: https://github.com/tonarino/webrtc-audio-processing/pull/23/files#diff-2fe5cefee42b0a50cdae6b4fe71600b8574c7127d629c49738414dd3ee45fe1aR50
I haven't actually played with the has_keyboard
flag but that would definitely be the first place I look to see if it makes a difference. Set it to true
and let us know if the keystroke sounds get reduced.
from webrtc-audio-processing.
@bschwind found the solution! turns out audio processor has a signal that you need to set before processing capture frame called set_stream_key_pressed
to indicate a key was pressed in this frame. I added it in my fork and it's working well (tested on macOS)
from webrtc-audio-processing.
@morajabi good find! I'd be happy to review and merge the change if you put up a PR.
from webrtc-audio-processing.
@bschwind I'd love to but It's based on #23 what should I do?
from webrtc-audio-processing.
Ahhh right.
Has #23 been working well for you? I think if so, we could polish it up and merge it. We're also using this library, but we could target a specific commit or tag instead if #23 doesn't work well for us (we had run into some issues with our setup but that might be a quirk to our own systems).
@skywhale what do you think?
from webrtc-audio-processing.
what issues have you ran into? because I think we need to provide more fine tuning for the config. in older version, we can set stream_delay and echo cancellation level. but in #23 it's not yet handled and it has worse cross talk performance (ie. it cancels a lot of actual signal in cross talk scenarios)
I'd love to hear your findings. if you believe master provides better performance and It's not configuration issue, I can backport my changes and add key_pressed support for that and switch to it.
from webrtc-audio-processing.
Related Issues (12)
- Stats should be made into an idiomatic Rust struct and publicly exported HOT 1
- 0.1.2 didn't include submodule HOT 2
- iDS camera shows repeated errors of code=178 HOT 2
- Make build errors more obvious
- Links dynamically to libwebrtc_audio_processing despite "bundled" flag.
- API improvement: consider a split() function HOT 1
- Add CMakeLists.txt for this project c packge HOT 3
- Fix linked C symbols on old macOS versions HOT 1
- Question: Is it possible to call `process_render_frame` multiple times for different streams? HOT 2
- What's blocking using latest freedesktop/pulseaudio-webrtc-audio-processing? HOT 1
- windows build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webrtc-audio-processing.