GithubHelp home page GithubHelp logo

RTL support about superslim HOT 3 CLOSED

tonicartos avatar tonicartos commented on July 18, 2024
RTL support

from superslim.

Comments (3)

mabdurrahman avatar mabdurrahman commented on July 18, 2024

Hi @TonicArtos

This fix is now partially broken, i've an issue on Grid Layout in RTL where the first view in a row starts to the Left instead of Right, and i found that replacing the next code:

// File: GridSLM.java, Method: fillRow(int markerLine, int anchorPosition, LayoutManager.Direction direction, boolean measureRowItems, SectionData sd, LayoutState state);
layoutChild(views[col], markerLine, col, rowHeight, sd, state);

with the code that was previously introduced by this commit, it works fine:

// File: GridSLM.java, Method: fillRow(int markerLine, int anchorPosition, LayoutManager.Direction direction, boolean measureRowItems, SectionData sd, LayoutState state);
layoutChild(views[col], markerLine, state.isLTR ? col : mNumColumns - 1 - col, rowHeight, sd, state);

And I found that you've removed this fix in this commit: fbad7b6

from superslim.

TonicArtos avatar TonicArtos commented on July 18, 2024

Thanks, I was surprised to learn I had missed picking this up.

from superslim.

TonicArtos avatar TonicArtos commented on July 18, 2024

@mabdurrahman Thank you for your feedback on this issue. Please let me know if there are any other issues with RTL support.

from superslim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.