save fails when copying sym links about godep

[kr]

Hopefully de4fb95 has fixed this satisfactorily.

Please reopen this issue (or open a new one) if there's still a problem.

[fkm3]

Sorry for the slow reply.

It doesn't choke on the sym link now, but the code in github.com/valyala/ybc/bindings/go/ybc/ has C dependencies in github.com/valyala/ybc/ that don't get copied. Maybe that is out of scope for this tool? Seems like I can just copy them manually for now.

[vcaputo]

@kr It needs to recur at the symlink, not simply preserve the symlink.

Imagine a project foo.com/bar where the directory structure is like this:

bin/
doc/
some_pkg -> src/some_pkg
src/
Makefile
README

The symlink is included just to cleanup the import path of some_pkg for external users:
import "foo.com/bar/some_pkg"
vs.
import "foo.com/bar/src/some_pkg"

While still allowing the project to have a clean separation of the code from everything else in the directory structure.

But if a project imports the path at the symlink and godep save is used, all it saves is the symlink.

[kr]

Godep can't simply follow symlinks, because that can result in pathological behavior. (Consider a symlink that points to its parent directory.) Godep is in a similar situation to the standard go tool with respect to symlinks. As Ian Lance Taylor put it:

Yes. In general the go tool does not work well with symlinks. There
is no current plan to change this. Any fix would have to describe a
complete and coherent solution for how symlinks should be handled. I
don't know what that would look like.

Godep is in the same boat.