bzr support about godep

[emicklei]

+1

[kr]

Note that with godep save -copy, explicit bzr support is unnecessary.

[ardan-bkennedy]

Hi Keith I really want to use the tool but I have projects using Bazaar and Mercurial. The mgo driver is my most important problem right now.

export GOPATH=$HOME/example
go get github.com/goinggo/mongorules
cd $GOPATH/src/github.com/goinggo/mongorules
godep save -copy

godep: Bazaar is unsupported: labix.org/v2/mgo
godep: Bazaar is unsupported: labix.org/v2/mgo/bson
godep: error loading dependencies

Am I doing something wrong?

[kr]

I was wrong, there are a couple of VCS-specific things godep does
in the save command:

• get the current commit id (e.g. git rev-parse HEAD)
• describe the current commit (e.g. git describe)
• ensure there are no uncommitted changes (e.g. git diff HEAD)

https://github.com/kr/godep/blob/master/vcs.go#L36-L38

These should be easy to add bzr support for.
I'll give this a shot today.

The other commands in that file vcs.go are the ones that
can be circumvented by -copy, and, in a happy coincidence,
those are the ones I would have trouble doing in bzr.

[kr]

@ardan-bkennedy please give this another try! :)

[ardan-bkennedy]

@ardan-bkennedy please give this another try! :)

godep save -copy
godep: dirty working tree: /Users/bill/example/src/labix.org/v2/mgo
godep: error loading dependencies

I cleaned out the workspace and used 'go get' to get the project and tried the latest version of the tool.

—
Reply to this email directly or view it on GitHub.

[kr]

What happens when you run this?

$ cd /Users/bill/example/src/labix.org/v2/mgo
$ bzr status

This tool uses bzr status to decide if any changes have been
made to the checked-out copy of each package. If the working
tree is dirty, the revision number will be wrong (since it won't
account for any changes in the working tree since the last
commit), so godep will refuse to use that dependency.

You could also try:

$ rm -rf /Users/bill/example/src/labix.org/v2/mgo
$ go get labix.org/v2/mgo
$ godep save -copy

[ardan-bkennedy]

What happens when you run this?

$ cd /Users/bill/example/src/labix.org/v2/mgo
$ bzr status
working tree is out of date, run 'bzr update'

So I ran the bar update command and everything worked

bzr update
M bson/bson.go
All changes applied successfully.
Updated to revision 246 of branch /Users/bill/example/src/labix.org/v2/mgo

cd github.com/OutCast-IO/DataTask/
godep save -copy

---

So this is great but also troubling. I guess go get did not properly get the code initially.

I may need to add this to the post

This tool uses bzr status to decide if any changes have been
made to the checked-out copy of each package. If the working
tree is dirty, the revision number will be wrong (since it won't
account for any changes in the working tree since the last
commit), so godep will refuse to use that dependency.

You could also try:

$ rm -rf /Users/bill/example/src/labix.org/v2/mgo
$ go get labix.org/v2/mgo
$ godep save -copy
—
Reply to this email directly or view it on GitHub.

[kr]

All software has bugs. The idea is for godep to do the
right thing in the common case. When the user runs
'go get', followed by 'godep save' or 'godep save -copy',
it should just work.

I'll open another bug for this.

[kr]

Just opened #15.