GithubHelp home page GithubHelp logo

Comments (4)

toolstack avatar toolstack commented on August 19, 2024

That's a function of gnome that I don't think I can change, I guess I could add a buffer to the top of the window so that the cheat sheet appeared below the close button, but that seems like a waste of space.

from folio.

toolstack avatar toolstack commented on August 19, 2024

Closing as wontfix.

from folio.

heldderarbeit avatar heldderarbeit commented on August 19, 2024

If you are open to suggestions regarding this - How about a regular headerbar? Here's how it would look like before / after.

image

Or another comparison with a different version, maybe moving up the first header to save space:

image

In that case the "Headings" line would be roughly on the same position.

Implementation-wise I found out that it's relatively easy: nesting the GtkMarkdownView in an Adw.StatusPage and replacing Adw.Window with Gtk.Window is enough.

using Gtk 4.0;
using Adw 1;

template $FolioMarkdownCheatsheet : Gtk.Window {

  default-width: 500;
  default-height: 440;
  titlebar: Adw.HeaderBar {};

  ShortcutController {
  …
  }

  Adw.StatusPage {
      css-name: _("status_page");

      $GtkMarkdownView text_view {

      tab-width: 4;
      …
      }
  }

}

That would bring 3 advantages:

  1. Scrollbar won't overlap anymore with close button
  2. it's not possible anymore to resize the window like this (resizing is completely blocked like in the keyboard shortcuts window):
    image
Screencast.from.2024-05-07.20-35-10.webm
  1. less code compared to now, for example ScrolledWindow is not needed anymore since scrolling is done automatically by Adw's StatusPage

If there is interest I could send a merge request for one of the headerbar versions (but really, there's not more code than I have listed here).

I would be very glad to see this realized since I very much like the general aesthetics of the app (it feels like it almost could belong to GNOME Circle and I would encourage you to apply your app for submission) but feel they are tarnished by the behaviour I described here. Therefore I stepped in to give some additional information and possible resolutions, despite having no prior experience with GTK elements beforehand.

It's a small change, but in my opinion would result in a much more professional look.

from folio.

toolstack avatar toolstack commented on August 19, 2024

I'd accept a PR for this, I'd title the status page "Markdown Cheetsheet" and remove the "Markdown Syntax" in the md file.

from folio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.