Comments (7)
I assume you haven't change the "Limit note width" setting? If so then this is mostly expected, though I agree that it should probably be able to go smaller than the fixed width, just not larger.
from folio.
Ok, so I looked into this and it appears to be expected behaviour with GTK4/Adwaita apps and the SourceView control that Folio uses.
Basically "Limit note width" is mislabelled, it should be "Set fixed note width".
Trying to auto re-size the widget would go against several of the GTK4/Adwaita principals so I'm not going to attempt that as it will just break again in the future more than likely.
Instead I'm going to commit two changes to resolve this issue:
- Relabel the preference
- Add a new pref to allow the user to set the fixed width size, at the moment it is 720, which will be the default
from folio.
libadwaita maintainer here, someone pinged me to take a look at this issue and I have no idea what principles you mean.
- AdwClampScrollable
- While looking at it I noticed that there's a toast overlay inside the scrolled window?.. Why? Put it right into the window instead
- GtkSourceView inside a GtkViewport (or AdwToastOverlay, for that matter) is not supported, so you likely broken scrolling on large notes right now. AdwClampScrollable should fix that too
from folio.
@alice-mkh thanks, I'm new to GTK/libadwaita but from what I saw it looks like monitoring window size changes is discouraged, which seemed to be the only way to reset the size of the sourceview widget if it was set to a fixed width instead of letting it fill the window.
I'll take a look at AdwClampScrollable.
from folio.
You don't need to monitor window sizes here, no.
if it was set to a fixed width
Right, don't do this. And you have to get rid of that toast overlay too (and of viewport if you added it manually, clamp scrollable replaces that)
from folio.
The primary notes area, by default, has a fixed with, so I can't just undo that easily without breaking existing behaviour. As such I've implemented an alternate solution that works for Folio.
I'll probably look at changing the default to non-fixed width in a future release though.
I took a quick look at clamp scrollable and don't think it will fit within the app at the moment, but I do have to do a major change at some point as Folio currently uses a lot of deprecated widgets, so I'll look more at it when I get to that.
from folio.
The primary notes area, by default, has a fixed with
Yes, which results in horizontal scrolling right with default window size. That's a bug, not something to preserve.
from folio.
Related Issues (20)
- Feature request: Typewriter scrolling HOT 1
- Typo in the spanish Translation HOT 1
- Weird unremovable notebook HOT 1
- Deleting a note creates a folder in the home directory HOT 1
- Markdown Highlight (==) Breaks Detected URL HOT 6
- Cannot run Version 24.10 AppImage: `GLIBC_2.38' not found HOT 1
- Search doesn't work as expected HOT 1
- Links with underscore (_) are hidden/Markdown styled & copy and pasting issue
- Git support & Extensions HOT 3
- Selected text is not highlighted HOT 4
- Cannot change where files are saved/stored HOT 2
- Editor slows down & Interesting editing HOT 5
- Unable to open files for editing in gvfs mount points HOT 3
- Feature Request: Only select the file name (not extension) after toggling rename of the note HOT 10
- Is there a way to run it on Windows? HOT 1
- Duplicate Note HOT 1
- Can't Use Hyperlinks HOT 3
- Feature request: document stats HOT 1
- Wiki links syntax support HOT 2
- Feature request: close to tray HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from folio.