Http headers about proxy-agents

[TooTallNate]

Can you show some example code please?

[razbomi]

Ok some context ... I am constantly pained with a corporate proxy thing. We have a bunch of angular thingies so angular-cli is the flavour of the month here. Hence I am running ng serve --proxy-config proxy.conf.js. The code in proxy.conf.js is something along these lines.

const HttpsProxyAgent = require('https-proxy-agent');
const PROXY_CONFIG = [
  {
    agent: new HttpsProxyAgent(process.env.HTTPS_PROXY || process.env.HTTP_PROXY),
    context: [
      "/api",
      "/uat",
      "/meow"
    ],
    target:  {
      host: "my.awesome.api.com",
      protocol: "https:",
      port: 443
    },
    secure: false,
    changeOrigin: true,
    logLevel: "debug"
  }
]

module.exports = PROXY_CONFIG;

So now if you make a request using curl, through the angular cli server which for me is on localhost:4200/api with an Authorization header, that header will not make it to the server hosting the https://my.awesome.api.com/api.

Now admittedly I haven't investigated properly what the angular cli thingie is actually doing with agent. However when I was reading through the code I made the assumption that headers from the original request are possibly ignored eg.

var headers = Object.assign({}, proxy.headers);

To be honest, I only read through the code... I'd be happy to write a test to prove it and/or raise a pull request if it is on this side instead of on the angular cli thingie

[TooTallNate]

This module has gone through a large refactor and modernization. I am closing this issue as a bit of house cleaning. If you feel that this issue still exists in the latest release, feel free to open a new issue.