Target Ruby Version 2.5 about rubocop-rails_config

[toshimaru]

Indeed, rubocop v0.76.0 still supports Ruby 2.3, so let's keep same supported Ruby version with rubocop. 🚶

I close this issue, if any concern let me know (or create another issue).

[koic]

FYI, Rails 6 has been updated to require Ruby 2.5 or higher.
rails/rails@1b7c322

I think it’s too early to use Ruby 2.4 because there might be many Ruby 2.3 users.

I completely agree. And RubyCop 0.62.0 (latest) still supports Ruby 2.2.

[nbibler]

Ruby 2.3 is End Of Life'd as of 2019-03-31:

Not maintained anymore (EOL):
Ruby 2.3.8
sha256: b5016d61440e939045d4e22979e04708ed6c8e1c52e7edb2553cf40b73c59abf

[SaimonL]

After updating the Rails gem now I get this error and Rubocop stopped working altogether.

Rails 5.2.3
Ruby 2.6.3

Error: Unsupported Ruby version 2.2 found inTargetRubyVersionparameter (in /Users/test/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-rails_config-0.5.1/config/rails.yml). 2.2-compatible analysis was dropped after version 0.69. Supported versions: 2.3, 2.4, 2.5, 2.6

I ran bundle exec rubocop --config .rubocop.yml

My project ".rubocop.yml"

inherit_gem:
  rubocop-rails_config:
    - config/rails.yml

AllCops:
  TargetRubyVersion: 2.6
  RubyInterpreters:
    - ruby

It completely ignores my local ".rubocop.yml" file

[toshimaru]

Hi, @koic, since Rails 6 has been released officially, I'm wondering if we could drop old Ruby versions - 2,3 and 2.4.

I'd say it's good time to drop. What's your opinion❓

[koic]

In fact, Ruby 2.4 is officially supported. Perhaps some rubocop-rails_config users are using Ruby 2.4 and RuboCop also supports Ruby 2.3.

IMHO, maintenance of rubocop-rails_config is not difficult even if it supports Ruby 2.3 and Ruby 2.4. So I think it would be beneficial for users to support Ruby 2.4 and Ruby 2.3.

I have one implementation idea.

• Leave gemspec required_ruby_version specified to >= 2.3.
• TargetRubyVersion of config/rails.yml is set to 2.5 according to Rails's .rubocop.yml.

However, there is a concern. If rubocop-rails_config specify 2.5 for TargetRubyVersion, it will be optimized to Ruby 2.5 or higher. Ruby 2.4 and Ruby 2.3 users means that compatibility may be broken if TargetRubyVersion is not changed to 2.3 or 2.4 from 2.5.

[toshimaru]

@koic thanks, I've decided rubocop-rails_config still supports Ruby 2.3+ and updated README about supported Ruby version https://github.com/toshimaru/rubocop-rails_config#targetrubyversion

BTW, Ruby 2.3 is already EOL-ed. so It sounds reasonable to drop Ruby 2.3 and support Ruby 2.4 or more. Do you think we still need to support 2.3?

[koic]

Yeah, I don't have a strong intention. Anyway, I think rubocop-rails_config can support Ruby versions that supported by RuboCop. It includes Ruby 2.3. Because maintenance cost of rubocop-rails_config does not increase for the opportunities available to rubocop-rails_config users.