Comments (1)
I'll try to persist some of my thoughts from the Gitter about this change, and also how it interacts with #118.
The proposed solution here is basically:
struct Buffer<T, Request, Executor = DefaultExecutor>
where T: Service<Request>
{
executor: Executor,
worker: Option<Worker<T, Request>>,
// ...
}
And then have poll_ready
be:
fn poll_ready(...) -> ... {
if let Some(w) = self.worker.take() {
self.executor.spawn(w);
}
// ...
}
With #118, the T: Service
bound on Worker
has to become T: DirectService<Request>
instead. To allow Buffer
to wrap regular Service
s, we also provide a DirectedService<T: Service>
wrapper that impl DirectService
by proxying poll_ready
and call
to T
and doing nothing for the other methods. But Buffer<T>
must now have the bound T: DirectService<Request>
if it is to contain the Worker
instance. While the user can specify that type, they'll have to know about DirectService
and the DirectedService
wrapper, which seems unfortunate. I don't have a clean workaround for this that doesn't involve Box
ing the Worker
.
As for hiding the concrete task type that needs to be spawned using this approach, I'm not sure how the solution outlined there fixes issue I raise above? We basically already have the proposed wrapper type (Worker ~= MyLibTask
), but this still doesn't hide Worker
(due to the E: TypedExecutor<MyLibTask<T>
bound). It also still reveals the T: DirectService
bound, and the DirectedService
wrapper, which seems unfortunate. I don't have a way of getting around that though sadly.
One alternative specifically for the DefaultExecutor
case would be to have Buffer::new
use future::lazy
and return impl Future<Item = Buffer>
. It's definitely a bit of a cop-out, but saves us from some of these thorny issues.
And finally, isn't it a little sad for Buffer
to carry along an Executor
? It probably doesn't matter too much for DefaultExecutor
, but are there other Executor
s where this might be a problem?
Overall, I think we should probably wait to make this change until after #118 lands.
from tower.
Related Issues (20)
- Adding Service Wrapper that allows to share services for compatibility with Axum route layers HOT 4
- Support weights for request rate limiting HOT 1
- Can I ask one question? HOT 4
- Publish `0.5` release HOT 5
- `Retry<RetryPolicy, RateLimit<Client>>` does not work HOT 7
- Idea: Preventing Inappropriate Service Invocation HOT 1
- Returning a response from a tower layer HOT 2
- AsyncFilterLayer is missing Clone impl
- Have MakeBalance and MakeBalanceLayer example?
- `Reconnect::new()` Generic parameters are redundant HOT 2
- Adding option_layer causes trait bound unsastisfied HOT 1
- Publish release without pin-project (with pin-project-lite) HOT 5
- `tower::service_fn` docs don't say that you need the `util` flag HOT 3
- MQTT client adapter / framework HOT 1
- βFan outβ services? HOT 3
- Consider using `ControlFlow` for retry `Policy`.
- Extending `Building a middleware from scratch` guide
- breaking change in tower design (0.6 or beyond): first class support for async fn traits HOT 20
- unexpected behaviour of `RateLimit`
- experiment with permit based service framework HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tower.