GithubHelp home page GithubHelp logo

Comments (4)

rogerdahl avatar rogerdahl commented on August 18, 2024

I'm just trying out the filelock module myself. In your function, what happens if a file that would have triggered the check that raises OSError() is created elsewhere between the check and the open()?

from filelock.

berkowitze avatar berkowitze commented on August 18, 2024

The function halts after the raise, so wherever that problematic locked_file was called will fail as well.
If the file is removed between the check and the open, that's more problematic you'll get a hanging lock file and not sure if it gets released. In my application, files aren't really removed so I'm not concerned about this personally.

from filelock.

Zooce avatar Zooce commented on August 18, 2024

Looking at the code, in UnixFileLock._acquire the call to os.open is not wrapped in a try-except, but WindowsFileLock._acquire does wrap the os.open call in a try-except.

from filelock.

gaborbernat avatar gaborbernat commented on August 18, 2024

Hello, if you make a PR for this (with tests) we would be happy to review it, thanks!

from filelock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.