Tss2_Sys_Initialize: missing some RC values implementation. about tpm2-tss

[wcarthur1]

Julian,

Good catch--yes, we missed those. Not sure when I’ll get to this. If you want, take a try at it yourself.

Will Arthur
Intel Corporation
Server Security Firmware
803-216-2101

From: juliantrzeciak [mailto:[email protected]]
Sent: Wednesday, September 23, 2015 8:44 AM
To: 01org/TPM2.0-TSS [email protected]
Subject: [TPM2.0-TSS] Tss2_Sys_Initialize: missing some RC values implementation. (#46)

Current implementation of Tss2_Sys_Initialize() in https://github.com/01org/TPM2.0-TSS/blob/master/sysapi/sysapi/ContextManagement.c

according to:
http://www.trustedcomputinggroup.org/files/static_page_files/28CE28FA-1A4B-B294-D0A965038809FE9B/TSS%20system%20API%2001.pdf
TSS System Level API and TPM Command
Transmission Interface Specification
Family "2.0"
Level 00, Revision 01.00
26 January 2015

page 32
misses following RC values:

TSS2_SYS_RC_INSUFFICIENT_CONTEXT: if for any reason there’s not enough memory.

TSS2_SYS_RC_BAD_VALUE: if any parameter has a bad value.

TSS2_SYS_RC_BAD_REFERENCE: if any of sysContext is a NULL pointer.

TSS2_SYS_RC_BAD_TCTI_STRUCTURE: if the implementation checks the TCTI function pointers and

any of the essential ones (transmit and receive) are set to NULL.

Any TPM or TCTI errors that could result from GetCapability calls that are made to get TPM version info.

TSS2_SYS_RC_INCOMPATIBLE_TCTI: unknown or unusable TCTI version.

Any plans in this subject?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/46.

[juliantrzeciak]

Will,

I'll take a try.

There may be another candidates, ex: Tss2_Sys_GetCpBuffer misses some trivial null pointer checks.

Do you prefer to have separate issue per function?

[wcarthur1]

Whatever is easiest for you.

Will Arthur
Intel Corporation
Server Security Firmware
803-216-2101

From: juliantrzeciak [mailto:[email protected]]
Sent: Thursday, September 24, 2015 7:23 AM
To: 01org/TPM2.0-TSS [email protected]
Cc: Arthur, Will C [email protected]
Subject: Re: [TPM2.0-TSS] Tss2_Sys_Initialize: missing some RC values implementation. (#46)

Will,

I'll take a try.

There may be another candidates, ex: Tss2_Sys_GetCpBuffer misses some trivial null pointer checks.

Do you prefer to have separate issue per function?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-142901264.

[juliantrzeciak]

log4fix: another candidate: Tss2_Sys_GetRpBuffer misses some trivial null pointer checks.

[wcarthur1]

Julian,

Did you ever do anything on this? If not, I'll take it.

Will

[juliantrzeciak]

Will,
Please take it.
Thanks,
Julian

2015-11-02 23:22 GMT+01:00 wcarthur1 [email protected]:

Julian,

Did you ever do anything on this? If not, I'll take it.

Will

—
Reply to this email directly or view it on GitHub
#46 (comment).

[wcarthur1]

Julian,

I fixed the issues and added tests for the various cases. Can you review my pull request?

Will

[wcarthur1]

Julian,

I goofed--my changes got merged into the main trunk as part of another change. Please review the changes in commit c7c4a12.

Will

[juliantrzeciak]

done.
thanks

[wcarthur1]

So, can I close this issue?

[juliantrzeciak]

yes

2015-11-03 19:26 GMT+01:00 wcarthur1 [email protected]:

So, can I close this issue?

—
Reply to this email directly or view it on GitHub
#46 (comment).

[juliantrzeciak]

Will,

Spec for Tss2_Sys_Initialize allows null pointer for tcti and abi, with further info what if.

Sorry for pointing it late.

Regards,
j

[wcarthur1]

Julian,

That’s been fixed in a more recent version of the spec.

Will Arthur
Intel Corporation
Server Security Firmware
803-216-2101

From: juliantrzeciak [mailto:[email protected]]
Sent: Friday, November 20, 2015 9:13 AM
To: 01org/TPM2.0-TSS [email protected]
Cc: Arthur, Will C [email protected]
Subject: Re: [TPM2.0-TSS] Tss2_Sys_Initialize: missing some RC values implementation. (#46)

Will,

Spec for Tss2_Sys_Initialize allows null pointer for tcti and abi, with further info what if.

Sorry for pointing it late.

Regards,
j

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-158411990.