Upgrade to node 16.x / npm 8.x about frontend

[miohtama]

trade-executor-frontend library depends on Node v16, as it is using one very handy v16 only function. Array.at(-1) to get the last item of the array.

So might need to upgrade sooner than later, as I need to bring the library to the main site.

[kenkunz]

I think it would be a good idea to enforce some consistency – both across dev team members and between dev & prod.

We could add the following to package.json

  "engines": {
    "node": "^16.14.0"
  },

and/or add an .nvmrc file.

I think my preference would be to specify engines.node but not commit .nvmrc. We already have an .npmrc file (note the p not v) with engine-strict=true (default when initializing a SvelteKit app), so setting an appropriate engines.node will cause npm install to fail if you're not running a supported version.

Developers may choose to use different node version managers (or just manually install/run a supported version), so setting .nvmrc (or .node-version) feels like a dev-specific preference. We can add .nvmrc to .gitignore and everyone can manage node versions as they see fit (as long as they pass the engines check).

OTOH, it can be beneficial to commit .nvmrc if your prod build toolchain uses this to determine the node version to run in prod (e.g., render, netlify, vercel, etc.). This is not the case for us afaik, so it feels unnecessary (and slightly prescriptive) to include it.

@miohtama, @servatj, @hieuh25, @allozaur – any opinions / thoughts on this?

[hieuh25]

For simplicity I usually do both specifying engines.node and adding ,nvmrc with same version in the repo. Yes it's a bit strict and limited but we will have consistency :D