GithubHelp home page GithubHelp logo

Clean up nginx config about docker-php-nginx HOT 2 OPEN

jduan00 avatar jduan00 commented on June 21, 2024
Clean up nginx config

from docker-php-nginx.

Comments (2)

TrafeX avatar TrafeX commented on June 21, 2024 1

Hi @jduan00,

Thank you for the tips. I've looked into it and came to the following;

  1. It's indeed not used, but it's part of the default nginx installation. I prefer to leave this alone because this container image serves as an example to adjust to your needs and I want to keep it simple and as standard as possible.
  2. That's indeed a good alternative for $document_root$fastcgi_script_name, but it's doesn't do exactly the same. I'm afraid this can create a backwards compatibility break, while it isn't a major improvement.

What I did change is removing the duplicate SCRIPT_NAME: b829e43

from docker-php-nginx.

jduan00 avatar jduan00 commented on June 21, 2024 1

Hi @TrafeX,

Thanks for the following up. It is matter of personal taste. I want to make it a min set of files within the container, thus I took the axe to get rid of anything that is not used.

Also, I appreciate you pointed out the difference about SCRIPT_FILENAME. https://serverfault.com/questions/465607/nginx-document-rootfastcgi-script-name-vs-request-filename

However, for our Laravel based PHP apps, the one works is:
fastcgi_param SCRIPT_FILENAME $request_filename;

Cheers,

Jack

from docker-php-nginx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.