Comments (9)
Should I understand the Starlette PR is doomed 😅 ?
I'm bothering ppl to review it... 😅
from prometheus-fastapi-instrumentator.
Async Python is a complete black box for me I have zero experience with so far (except the little bit I interact with it in FastAPI). So if you know a way to refactor the code, please go on. Would be awesome
from prometheus-fastapi-instrumentator.
I've found a very insightful article yesterday: https://florimond.dev/blog/articles/2019/08/introduction-to-asgi-async-python-web/
But anyway, thank you. I'll be working on it then (it should not be many changes, only focused on the middleware interface).
from prometheus-fastapi-instrumentator.
Took me a few hours today to get to this issue 😄
Glad to see it has already been worked on, thanks @Kludex and @trallnag 🙂
Any way I can help moving this forward?
from prometheus-fastapi-instrumentator.
Oh, I see @Kludex is also working on resolving the original issue in Starlette.
from prometheus-fastapi-instrumentator.
Any way I can help moving this forward?
Yes, you can take my PR: #23 .
Oh, I see @Kludex is also working on resolving the original issue in Starlette.
🏃 💨
from prometheus-fastapi-instrumentator.
Should I understand the Starlette PR is doomed 😅 ?
I'll see if I can continue your work once @trallnag has given us updates (on this PR or on the CI one) 🙂
from prometheus-fastapi-instrumentator.
Hi all,
would it be possible to get a status update here?
Does the close on this PR means this will never be implemented? encode/starlette#919 or it's fixed via: encode/starlette#1715?
Does anybody have/tested a workaround, like: encode/starlette#919 (comment) ?
thanks
from prometheus-fastapi-instrumentator.
This was already fixed here.
from prometheus-fastapi-instrumentator.
Related Issues (20)
- Inprogress requests causes duplicated prometheus timeseries error
- labels on highr bucket default metrics
- Having metrics values even with no endpoints activity HOT 1
- Not full metrics list HOT 1
- FastAPI app with many routers HOT 3
- Instrumentator middleware includes BackgroundTask duration in http request latency metrics
- How to properly initialize modified_status when throwing exception
- Default metrics are gone when adding a custom instrumentation HOT 3
- Allow for custom dynamic labels on default metrics HOT 1
- Remove FastAPI in favor of Starlette HOT 3
- Upgrade fastapi version to support >100.0 HOT 5
- Metrics disappear when setting PROMETHEUS_MULTIPROC_DIR HOT 1
- Security Concern HOT 3
- Inprogress metrics ignore namespace and subsystem
- Setting the `PROMETHEUS_MULTIPROC_DIR` is not mentioned in the docs
- Instrument latency without streaming duration HOT 1
- FastAPI ^0.110 and on_event HOT 2
- Incorrect http_requests_total with multiple Middleware HOT 1
- trio / anyio support
- [TypeError("'ObjectId' object is not iterable"), TypeError('vars() argument must have __dict__ attribute')] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prometheus-fastapi-instrumentator.