Comments (3)
Nice, sounds reasonable to me, however, I don't think I'll have availability to work on this anytime soon. But I'll put it in my backlog for later, I hope you can understand.
If you want to try to do it yourself feel free, and I'll be happy to assist you.
from label-requires-reviews-action.
Hello! Just to verify I understood your request correctly, there are two issues here:
On one hand, you would like to timestamp the reviews and expire them if a new commit is applied on top?
And in the other hand, you would like to enforce Required approving reviews
for other branches than master (i.e. epic branches).
Did I understand it correctly?
from label-requires-reviews-action.
sorry about describing two issues in one GH issue thread 😓
On one hand, you would like to timestamp the reviews and expire them if a new commit is applied on top?
Correct, essentially mimic the "Dismiss stale pull request approvals when new commits are pushed" without needing to check "Require pull request reviews before merging" to then check the "Dismiss stale.." rule.
And in the other hand, you would like to enforce Required approving reviews for other branches than master (i.e. epic branches).
Correct, I think. The idea is to not make the branch protection rule "Require pull request reviews before merging" a requirement. If this does not need to actually be done then that is great, the mimic of "Dismiss..." to ensure accurate approval status is the core issue being faced.
from label-requires-reviews-action.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from label-requires-reviews-action.