GithubHelp home page GithubHelp logo

Comments (5)

malakhov-dmitrii avatar malakhov-dmitrii commented on August 21, 2024 1

Strongly agree about this one!
If this project has plans to grow, className and children is 100% must have (otherwise why do we even need to install tailwind, and now I need to use div wrappers even for basic styles adjustments)

from tremor.

mitrotasios avatar mitrotasios commented on August 21, 2024

Hi, thanks a lot for the comments. Totally agree on the point about the children, we will fix this soon.

Regarding the className, this is definitely something we do consider for the next major release as well, given the amount of comments it got. As mentioned in other comments, the initial idea had been to provide a limited amount of props per component with a relatively low degree of customisation, in order to "enforce" an opinionated design to the end-user, which enables a fast development workflow. But we will re-evaluate the degree of customisation.

Please note, installing tailwind is not required to run tremor, it is listed as a devDependency.

@LucasAlda @Hennessy811 that is not a great dev-experience indeed, may I ask what kind of adjustments you are looking for? Would you also mind if we reach out to you in the future for feedback on the library? It would help us a lot!

from tremor.

LucasAlda avatar LucasAlda commented on August 21, 2024

I totally agree with the idea of giving an opinionated design to the end-user without any complexity, and that's why my proposal is the ability to overwrite the default ones.

Example: The Text component className is "tr-shrink-0 tr-mt-0 tr-text-left tr-text-gray-500 tr-text-sm tr-font-normal"

"tr-mt-2" replaces "tr-mt-0," allowing for simple and flexible configuration without redefining all of the great styles you've already added. 

PD: check https://www.npmjs.com/package/tailwind-merge recommended on twitter by @tannerlinsley

from tremor.

LucasAlda avatar LucasAlda commented on August 21, 2024

Also it hasn't need to be called "classNames", can be something more descriptive and in cases where you have multiple nested components there can be multiple props ('legend-...', 'axes-...', 'footer-...', 'label-...')

from tremor.

github-actions avatar github-actions commented on August 21, 2024

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from tremor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.