Comments (5)
Strongly agree about this one!
If this project has plans to grow, className and children is 100% must have (otherwise why do we even need to install tailwind, and now I need to use div wrappers even for basic styles adjustments)
from tremor.
Hi, thanks a lot for the comments. Totally agree on the point about the children, we will fix this soon.
Regarding the className
, this is definitely something we do consider for the next major release as well, given the amount of comments it got. As mentioned in other comments, the initial idea had been to provide a limited amount of props per component with a relatively low degree of customisation, in order to "enforce" an opinionated design to the end-user, which enables a fast development workflow. But we will re-evaluate the degree of customisation.
Please note, installing tailwind is not required to run tremor, it is listed as a devDependency.
@LucasAlda @Hennessy811 that is not a great dev-experience indeed, may I ask what kind of adjustments you are looking for? Would you also mind if we reach out to you in the future for feedback on the library? It would help us a lot!
from tremor.
I totally agree with the idea of giving an opinionated design to the end-user without any complexity, and that's why my proposal is the ability to overwrite the default ones.
Example: The Text component className is "tr-shrink-0 tr-mt-0 tr-text-left tr-text-gray-500 tr-text-sm tr-font-normal"
"tr-mt-2" replaces "tr-mt-0," allowing for simple and flexible configuration without redefining all of the great styles you've already added.
PD: check https://www.npmjs.com/package/tailwind-merge recommended on twitter by @tannerlinsley
from tremor.
Also it hasn't need to be called "classNames", can be something more descriptive and in cases where you have multiple nested components there can be multiple props ('legend-...', 'axes-...', 'footer-...', 'label-...')
from tremor.
🎉 This issue has been resolved in version 2.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from tremor.
Related Issues (20)
- [Bug]: Select, Search Select and MultiSelect components have changed behaviour when clicked on via mouse
- [Bug]: Charts don't render in React 19 RC HOT 5
- Add type="search" for TextInput
- [Feature]: Provide a tailwind preset
- [Feature]: Allow toggling axisLine for XAxis and YAxis
- [Feature]: Allow displaying data labels on bar, line, pie and area through props
- Rounding on barcharts? HOT 1
- [UTs coverage]: Add UTs for AreaChart, BarChart, SparkAreaChart, Legend components HOT 1
- [Bug]: When Tooltip overlaps on surrounding charts, the zindex seems to be too low HOT 1
- [Bug]: The selected elements don't change their background color HOT 1
- BarList aligment HOT 5
- [Feature]: Progree bar color and background color HOT 1
- [Bug]: Select does not apply error styling in dark mode HOT 3
- [Bug]: TabGroup doesn't follow the colours defined in tailwind.config.ts HOT 8
- [Feature]: React 19 support HOT 1
- [Bug]: Legend component fails to render with 23 or more categories HOT 1
- [Feature]: Stacked Funnel Chart HOT 3
- [Feature]: Value Formatter for x-axis
- [Feature]: Padding for x axis
- [Feature]: Progress Circle with different color by sector HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tremor.