compatibility issue with datapicker widget about jquery-timepicker-addon

[trentrichardson]

I have noticed this bug as well and am working on a fix

[rosali]

The following fixed getDate issue. setDate method is still a problem.
[code]
//#######################################################################################
// override getDate() to allow getting time too within Date object
//#######################################################################################
$.datepicker._base_getDateDatepicker = $.datepicker._getDateDatepicker;
$.datepicker._getDateDatepicker
= function(target, noDefault) {
var inst = this._getInst(target),
tp_inst = this._get(inst, 'timepicker');
//timepicker instance exists
if (tp_inst)
return (!inst.currentYear || (inst.input && inst.input.val() == '')) ?
null :
(new Date(inst.currentYear, inst.currentMonth, inst.currentDay, tp_inst.hour, tp_inst.minute, tp_inst.second));
//timepicker instance does not exist
else return new Date(inst.currentYear, inst.currentMonth, inst.currentDay);
};

[/code]

[trentrichardson]

Hey Rosali,

For an immediate fix that should work ok, however, this does bypass a lot of datepicker functionality. Thanks for posting the quick fix though, I may use this for the time being.

Trent

[trentrichardson]

Hey Rosali,

Please check out the dev version, it should work now. Please let me let me know if so.

[agentphoenix]

I pulled doublerebel's unstable branch to fix the hourMin/hourMax bug, but now I'm running in to the datepicker issue that's fixed on this branch. Are both of these issues going to be in the 0.9.2 release when it's ready?

[trentrichardson]

We will merge our bug fixes for 0.9.2, so they will both be included

[trentrichardson]

Also if you need this fix just look at the lines replaced in my latest dev, its only a couple lines and you can just completely swap my new function with the old one:

$.datepicker._getDateDatepicker

[agentphoenix]

Thanks for the tip. I gave it a try, but it didn't work.

Firebug is throwing the error this._get(inst, "timepicker") is undefined and it's showing the error as being on line 600 of timepicker.js.

[trentrichardson]

that should be a conditional.. if you feel comfortable reworking it into:

var tp_inst = this._get(inst, "timepicker");
if(tp_inst) tp_inst._addTimePicker();

[agentphoenix]

Worked beautifully! Thank you for all your help, you've been awesome!

[trentrichardson]

Fixed in dev branch, closing