Regular expresion in query param? about highlight-words

[tricinel]

Ok, great! I can see use cases here, so I'm going to do it.

[tricinel]

Hey @eriknyk, thanks for trying it out!

Could you try this:

stacktraceChunks = highlightWords({
  text: item.stackTrace,
  query: '/(com.mycompany[\.0-9a-z]+)/'
});

Notice the / missing from your query.

Cheers,
Bogdan

[tricinel]

Ok, cool! I'll polish everything and publish the new version. Thanks for testing and for your suggestion 👍

[tricinel]

@eriknyk 1.2.0 is published. I'd appreciate a final run through 🙏

[eriknyk]

I just can say THANK YO USO MUCH! @tricinel

[tricinel]

Hey @eriknyk, thanks for getting in touch! Hmm, I haven't considered that use case, so it's not possible at the moment. I'm specifically escaping anything that might look like a regex. I guess it's something we could not do. We could check if the term is a regex and, if it is, let it pass through, otherwise escape as I do now.

I'd like to write some test cases first.

Would you mind sharing a few examples of what you had in mind? Mock code will do just fine.

[eriknyk]

Yeap for sure, Thanks @tricinel

my principal use case is when I want to highlight words with a given pattern like /com.mycompany.com[\.0-9a-z]+/
in this case I want to highlight all strings like

com.mycompany.com.authorization.config

com.mycompany.com.core

com.mycompany.com.controllers.invoices

patterns like that in a very very long text like we have in the android logcat crash reports.

Thanks a lot

[tricinel]

@eriknyk something like this.

I published 1.2.0 as a beta. I need to polish it a bit and update the docs, but this should give you an idea and you can tell me if it fits your purpose :)

https://www.npmjs.com/package/highlight-words/v/1.2.0-beta.0

npm install [email protected] or the yarn equivalent should work I think.

You'll see the example for your test case here - and notice that you'll need to use a capture group, i.e. /(com.something.something.else)/ for the split to work properly.

[eriknyk]

Awesome @tricinel,
however, I've update to

"highlight-words": "^1.2.0-beta.0",

but the regex not working.

My code:

stacktraceChunks = highlightWords({
	text: item.stackTrace,
	query: '(com.mycompany[\.0-9a-z]+)'
});

[eriknyk]

It works perfectly!
thank you so much @tricinel

[tricinel]

Ah, very nice! Glad it's working! You're very welcome 👍 It was a nice suggestion and I'm sure a useful addition for everyone.