Server Fails to Start When HTTPS is Disabled about trino

[wendigo]

@mosabua can you check whether this is stated in the docs?

[wendigo]

This is not a bug. Configuration system is strict - if some configuration properties apply only when some other property is true (like in this case), unused properties are treated as error

[Akanksha-kedia]

@wendigo can you explain on this a little please. How its not a bug

…

On Mon, 1 Apr 2024 at 2:48 PM, wendigo ***@***.***> wrote: Closed #21339 <#21339> as not planned. — Reply to this email directly, view it on GitHub <#21339 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVL2AZQSQFQ4OG7DLTNNAW3Y3EQ5DAVCNFSM6AAAAABFRKHFR2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMYDQNRVG4ZTSNY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Akanksha-kedia]

@wendigo

I understand your point. This is more about improving the user experience with the configuration system. While the strict configuration system helps to prevent misconfigurations, it can be tedious in cases like this where disabling a feature doesn't ignore the related properties.

[Akanksha-kedia]

and also https://trino.io/docs/345/security/tls.html on 345.0

and having unused properties, we are successfully able to start the service.presto 3379312 1 99 09:36 ? 00:01:23 java

[wendigo]

@Akanksha-kedia as I've said - this is not a bug. Allowing unused properties does not improve user experience, just the opposite - makes the configuration more error prone. Leads to situations where typos and deprecate properties are accepted but not applied. This strictness of the configuration won't be relaxed and it's up to the user to provide a configuration that is valid. Error messages are informative enough to fix a configuration.

[wendigo]

If the incorrect configuration was somehow accepted in 345 it was definitely a bug, not a correct behavior

[Akanksha-kedia]

Thanks for the information, can we have document this or we are good without any document regarding this.

[mosabua]

The general behavior around strictness and such?