GithubHelp home page GithubHelp logo

dtrace optional? about node-triton HOT 8 OPEN

tritondatacenter avatar tritondatacenter commented on August 18, 2024
dtrace optional?

from node-triton.

Comments (8)

trentm avatar trentm commented on August 18, 2024

@lloydde just confirming: you get the same with 'npm install smartdc' right?

from node-triton.

dwlf avatar dwlf commented on August 18, 2024

@trentm sorry, already installed mac command line tools and npm installed again.

from node-triton.

trentm avatar trentm commented on August 18, 2024

@lloydde I don't know what you mean. Could you please try this:

mkdir play
cd play
npm init .     # take all the defaults here
npm install smartdc

Do you get the same error with dtrace-provider building?

from node-triton.

dwlf avatar dwlf commented on August 18, 2024

@trentm at the time of my issue, I didn't have "mac xcode or mac command line tools installed" (see initial comment), I now do.

from node-triton.

trentm avatar trentm commented on August 18, 2024

Ah, I see. Thanks.

from node-triton.

bahamas10 avatar bahamas10 commented on August 18, 2024

has this been resolved?

from node-triton.

trentm avatar trentm commented on August 18, 2024

@bahamas10 No. I don't have a great answer here. Bunyan has been rounds on whether to make dtrace-provider an optional dependency... almost always because of build failures. A while back those cases were fixed/worked-around by having the dtrace-provider build not fail on non-dtrace-y platforms and to be very silent (it was noisy in that case for a while).

This is a new case: dtrace-y platform, no build tools. I'm guessing that Mac is going to be the only common such case. While I would hope that the set of those using Mac, interested in Triton, and not having the Xcode CLI tools installed is smaller... I don't think we can discount it.

I'm hesitant to make it an optional dep for bunyan. From a pure bunyan-advocate p.o.v., making dtrace-provider optional means that failures to build won't get noticed/reported... the dtrace features of bunyan will suffer.

The only solutions I see:

  1. have bunyan make dtrace-provider and optional dep
  2. have bunyan depend on a "dtrace-provider-if-can" fork (the name could be whatever, or could consider trying to get it upstreamed) that would allow certain kinds of failures. The single starting case would be Mac not having the build chain. Perhaps emit a warning and move on
  3. binary built modules support in npm core :)

from node-triton.

trentm avatar trentm commented on August 18, 2024

I suppose a mitigation might be to look into avoiding the runtime warnings and just have the install time noise.

from node-triton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.