GithubHelp home page GithubHelp logo

Comments (7)

PiotrSikora avatar PiotrSikora commented on May 27, 2024

It definitely looks like it:
https://github.com/joyent/smartos-live/tree/master/src_addon/cpp

from smartos-live.

rmustacc avatar rmustacc commented on May 27, 2024

Yes, we are using a different cpp. While, we could redistribute the S10 or OI 151a cpp, we don't have the source to it and it is not a viable long term solution. Improving the current cpp would not be a bad thing, but either someone needs to implement it, or pull in and really test another one.

from smartos-live.

 avatar commented on May 27, 2024

I see it's partly written by Joerg Schilling - perhaps its worth filing a bug report with him? He is pretty good at fixing bugs in things he has written iirc.

from smartos-live.

richlowe avatar richlowe commented on May 27, 2024

There're a few issues:

  1. Whatever is causing the 'r' message
  2. The fact our va_impl header really does use #error(...) which really is wrong
  3. The fact we're reaching the branch in which the #error even occurs

I'm hoping that 1 and 3 relate. I may make some time to look into this (don't rely on this happening though)

from smartos-live.

richlowe avatar richlowe commented on May 27, 2024

The commit above (either, they're the same, not sure what I screwed up beyond the spacing) should deal with point 3.
point 2 will always exist for this cpp, as it doesn't actually support #error or #warning.

I haven't looked into the mysterious 'r' yet.

from smartos-live.

richlowe avatar richlowe commented on May 27, 2024

Sigh. I seem to be having real bad luck with missing that debugging gunk made it into the index. I'm going to cease spamming the bug with fixups.

The commit above (complete with gunk!) fixes the 'r' report by actually correcting error reporting so that we can see the real error: /usr/include/python2.6/pyconfig.h: 1004: _FILE_OFFSET_BITS redefined

Which makes a lot more sense. This looks to be because we're explicitly entering the largefile environment with -D on the dtrace command line, but also with a #define in pyconfig.h.

This error exists with the normal cpp also

/usr/lib/cpp -D__sun -D__unix -D__SVR4 -D__SUNW_D=1 -D__SUNW_D_64 -D__SunOS_5_11 -D__i386 -DPHELPER -I. -I/usr/include/python2.6 -I/usr/gnu/include/ncurses -D_LARGEFILE64_SOURCE -D__SUNW_D_VERSION=0x01009000 -D__STDC__=0 phelper.d
"/usr/include/python2.6/pyconfig.h", line 1004: macro _FILE_OFFSET_BITS redefines previous macro at "/usr/include/sys/feature_tests.h", line 209

The command line being taken from that eventually passed to cpp from dtrace

from smartos-live.

rmustacc avatar rmustacc commented on May 27, 2024

This has been fixed with Rich's work, see the pull request referenced above.

from smartos-live.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.