vmadm boot fails "Cannot find disk" about smartos-live

[joshwilsdon]

Daniel, can you confirm that this works if you change vmobj.zoneroot to vmobj.zonepath in /usr/vm/node_modules/VM.js? Sorry about that, I'll fix in our branch and talk to John tomorrow about whether we can get a new release built.

[MerlinDMC]

currently i can't compile SmartOS will try tomorrow if noone else goes for it

but i think it should be vmobj.zonepath + "/root" or just working_dir

[joshwilsdon]

You should be able to test without rebuilding by doing:

cp /usr/vm/node_modules/VM.js /var/tmp/VM.js
chmod 755 /var/tmp/VM.js
mount -F lofs /var/tmp/VM.js /usr/vm/node_modules/VM.js

and then editing the file.

[joshwilsdon]

You are correct (I just confirmed) the fix is to change to:

if (!found && path.existsSync(vmobj.zonepath + '/root/' + disk.path)) {

I've tested this here and committed to our internal repo. I'll ask tomorrow if we can get that bit pushed upstream asap.

[jclulow]

I think it's probably better to use path.join, thus:

if (!found && path.existsSync(path.join(vmobj.zonepath, 'root', disk.path))) {

[joshwilsdon]

Good call. I've done it with path.join now. Thanks!

[JohnSonnenschein]

Pushed to smartos-live. I'll rebuild another iso/usbkey since this is a pretty major bug (makes it hard to provision vms without it)