Comments (5)
talhasch
commented on May 26, 2024
1
Yeah thats right! Also min-confirmation has to be checked while removing and owner...
from multisafe.
LNow
commented on May 26, 2024
It can be also set up to be greater than current number of owners and result will be the same - permanent contract lock.
from multisafe.
talhasch
commented on May 26, 2024
Thanks for reported @LNow Thats a nice catch! Fixed
from multisafe.
LNow
commented on May 26, 2024
Hey @talhasch! There is still a loophole I mentioned in 2nd comment.
You can change min-confirmation to be greater than current number of safe owners and you'll end up with locked safe.
from multisafe.
talhasch
commented on May 26, 2024
Validations added to guarantee that min-confirmation always equal or lower than owner count.
from multisafe.
Related Issues (15)
- Use send-many-memo for STX transfers HOT 1
- A list of improvements
- A public function to get transaction count
- [BUG] One "transaction" can be executed multiple times. HOT 1
- Add 'get-owners' or 'get-info' function to safe-trait HOT 2
- Open sourcing frontend code for app.multisafe.xyz HOT 1
- License is missing from this repository and needs to be added HOT 1
- In UI there it is not possible to revoke a pending, unauthorized transaction HOT 3
- FT and NFTs do not display correctly on testnet MultiSafes because metadata is disabled HOT 4
- Crucial functions are secured with `tx-sender` HOT 3
- Buffer size use is limited HOT 2
- app.multisafe.xyz should have a link back to docs or this repo HOT 1
- Deposit not showing in safe HOT 2
- Changing `min-confirmations` affects all transactions HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from multisafe.