GithubHelp home page GithubHelp logo

Comments (3)

ricardobeat avatar ricardobeat commented on May 2, 2024

Working at https://github.com/ricardobeat/Ghost/commits/settings_api

I wrote a few tests but for some reason am getting SQLITE_IOERR: disk I/O error when more than one test is ran (I left them commented out). Nodeunit runs tests in series, not in parallel, so I don't know what's going on there. Promises are weird.

Ghost should have an init method and/or accept a callback/return a promise.

Finally, I don't see why the API module should load it's own Ghost instance, the one created in app.js should be fed to it.

Feedback welcome/wanted.

from ghost.

ErisDS avatar ErisDS commented on May 2, 2024

Without doubt ghost.js needs a refactor. If you have time & ideas, by all means please submit pull requests with refactoring changes, just keep them separate to feature changes so that I can merge more quickly.

I'm not sure whether to stick with nodeunit or use mocha as that seems to be a more popular choice, as well as being more feature-rich.

from ghost.

tgriesser avatar tgriesser commented on May 2, 2024

That seems like an odd error to be get... The sqlite3 pool should only be allowing for one connection, and should take care of that behind the scenes... I wonder what else might be going on here, do you know what version of sqlite your machine is running?

I'll have to take a look later and see if I can reproduce it.

from ghost.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.