GithubHelp home page GithubHelp logo

Comments (12)

matthojo avatar matthojo commented on May 2, 2024

With this I'm currently implementing the iCheck library but do we need it to be global? or just Settings page?

from ghost.

matthojo avatar matthojo commented on May 2, 2024

Is this issue complete, or are we keeping it open until everything is finalised?

from ghost.

JohnONolan avatar JohnONolan commented on May 2, 2024

Need a report on a few things:

  • What's the weight of the library?
  • Is it easy to work with?
  • What areas have we implemented it in so far?
  • Are we calling it on every page, or just in certain areas?
  • Did you research/find any viable alternatives?
  • Is the library being actively maintained?

from ghost.

matthojo avatar matthojo commented on May 2, 2024

What's the weight of the library?

11kb

Is it easy to work with?

Very

What areas have we implemented it in so far?

Just the settings page checkboxes

Are we calling it on every page, or just in certain areas?

I'm currently only calling it in the settings page, but can put it globally very easily.

Did you research/find any viable alternatives?

Nope but can do if you like.

Is the library being actively maintained?

Yup, last commit 4 days ago. https://github.com/damirfoy/iCheck

from ghost.

JohnONolan avatar JohnONolan commented on May 2, 2024

@ErisDS any objections? I don't like 11kb size, but tbh it does add a level of polish that's very desirable and generally uncommon which I think is fairly important. Maybe trial it for now and kill it if it gets in the way?

from ghost.

matthojo avatar matthojo commented on May 2, 2024

I agree, it appears to be variable based on if retina / non-retina graphics are used.
I've got no problem trialing it.

from ghost.

ErisDS avatar ErisDS commented on May 2, 2024

As a developer, and not a designer, I believe that all of these sorts of things are tosh and that native checkboxes are best.
However, given that I will never win that argument, I don't see a problem with this particular library. My issue will come if you then want to use another separate library for selects or some other field.

from ghost.

JohnONolan avatar JohnONolan commented on May 2, 2024

Cool - let's test it and see how it goes.

from ghost.

matthojo avatar matthojo commented on May 2, 2024

Can this be closed now?

from ghost.

JohnONolan avatar JohnONolan commented on May 2, 2024

@matthojo where have you implemented this that I can see it in action?

from ghost.

matthojo avatar matthojo commented on May 2, 2024

settings page as the checkboxes.

from ghost.

JohnONolan avatar JohnONolan commented on May 2, 2024

The plugin itself looks good - the implementation is a mess. We absolute don't want to use any 3rd party CSS files. We should choose a look and implement our own css properly for this.

I would suggest something similar to the "square" skin

image

But using Ghost blue, smaller boxes, and without using any images.

from ghost.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.