Clicking on 'About' in the menu crashes the app. about android-app

[ashutoshgngwr]

#12 works on Android Pie emulator but not on a physical device. Needs more work!
The origin of the bug is in AboutPage dependency which is implicitly trying to change Day and Night mode configuration on the fragment ultimately causing the activity to be recreated. Activity recreation causes SoundLibraryFragment to be recreated in background which means it won't initialize its views. Service is rebound to it and RecyclerView's adapter is refreshed when RecyclerView wasn't initialized.

This is also likely to happen with PresetFragment which also uses similar pattern.

[ashutoshgngwr]

I went through the source code of AboutPage. It does not seem to be causing the problem. Since I do not have a physical device with Android Pie and there is no other way to reproduce this behaviour, I did a workaround to avoid crash (#15). I'll leave this open until the exact origin of this bug is pinpointed and fixed.

[ashutoshgngwr]

I am closing this. I give up. 😓
The workaround works. End of STORY!

[ashutoshgngwr]

Corresponding stacktrace

kotlin.UninitializedPropertyAccessException: 
  at com.github.ashutoshgngwr.noice.fragment.SoundLibraryFragment.getMRecyclerView (SoundLibraryFragment.java)
  at com.github.ashutoshgngwr.noice.fragment.SoundLibraryFragment$mServiceConnection$1.onServiceConnected (SoundLibraryFragment.java)
  at android.app.LoadedApk$ServiceDispatcher.doConnected (LoadedApk.java:1725)
  at android.app.LoadedApk$ServiceDispatcher$RunConnection.run (LoadedApk.java:1757)
  at android.os.Handler.handleCallback (Handler.java:873)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:193)
  at android.app.ActivityThread.main (ActivityThread.java:6762)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:858)