Comments (8)
First: I hope i don't annoy you with all of my tickets. If that is the case, let me know^^
No. Your issues are clear and highlight some problems and real bug. It help me a lot ;)
ok so if I understand you want to change the ha no you want option to configure the RawPathParams. Ok, it should be not a problem ;)useValidation
to true
by default ?
from tsed.
The problem described in the doc required that the validation is disabled, because in this case, the validator will take the PersonModel as schema validation. It's completely wrong, because, the input is an ID.
I realize my example is probably not complete to reflect a real valid usecase. The correct custom decorator implementation should be that:
import {string} from "@tsed/schema";
export function UsePersonParam(expression: string): ParameterDecorator {
return useDecorators(
RawPathParams({expression, useValidation: true, useType: String}),
Schema(string().required().pattern("some pattern")),
UsePipe(PersonPipe)
);
}
But it's not the problem of your issue here ;)
from tsed.
PR ready #2517
from tsed.
Hey @Romakita,
with your explanation i managed to create a decorator by:
return PathParams({
expression,
useType: Number
}
i was not 100% aware of the useType
- but i think your pr makes sense anyway?
from tsed.
The useType is here to override the original type set on the parameter. By default Ts.ED use the metadata stored by Typescript to generate the schema validation. But in this case, the type set on parameters is the final result expected by the dev, but the type that should be used as model validation for ajv ;). So it's really important to override it (for ajv and swagger doc).
from tsed.
Awesome, useType: Number
works like a charm for me here 👍🏼
from tsed.
🎉 Are you happy?
If you appreciated the support, know that it is free and is carried out on personal time ;)
A support, even a little bit makes a difference for me and continues to bring you answers!
from tsed.
🎉 This issue has been resolved in version 7.44.0 🎉
The release is available on:
v7.44.0
- GitHub release
Your semantic-release bot 📦🚀
from tsed.
Related Issues (20)
- [BUG] Dependencies issue when update Mikro orm to v4.5.0 + HOT 2
- [BUG] Update temporal.io dependencies causing issue HOT 2
- [BUG] Dependency injection w/ useAsyncFactory returns Promise on 2nd invoke() HOT 3
- Link Checker Report HOT 1
- [BUG] Missing repository's d.ts after running 'npm run prisma:generate'
- Override reconnectOnError in tsed ioredis module HOT 3
- Enhance Context Management for event listeners in `SocketHandlersBuilder` HOT 2
- [BUG] Lack support for ACK callbacks HOT 2
- Missing the basics HOT 4
- [BUG] Swagger UI no longer loads HOT 5
- Link Checker Report HOT 1
- [BUG] `deepClone` does not respect built-in objects like `Set` and `Map` HOT 2
- [BUG] Swagger UI no longer loads HOT 36
- [BUG] Swagger issue on loading an undefined resource HOT 9
- [BUG] Custom `.Error` does not work on schemas other than `@Required` HOT 3
- [BUG] How do i add a description to a `@BodyParams` HOT 2
- [BUG] tsed doesn't work with Nx Workspace HOT 1
- [BUG] ESM error in BullMQModule HOT 3
- [BUG] Children Controller Routes should be declared before parent HOT 10
- [BUG] package installation of @tsed/typeorm and typeorm produces dependency conflict HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tsed.